This was giving me trouble at some point, though I think the actual case that was bothering me has already been fixed. I just did this by manual inspection.

Thanks for doing this!

Comment on attachment 8480136 [details] [diff] [review] Add explicit ctor annotations in DMD.cpp. Review of attachment 8480136 [details] [diff] [review]: ----------------------------------------------------------------- ::: memory/replace/dmd/DMD.cpp @@ +2061,5 @@ > RecordKey key(b); > RecordTable::AddPtr p = table->lookupForAdd(key); > if (!p) { > + const RecordKey k(b); > + Record tr(k); Whoa, that was dubious. I think you can use |key| from above and not create |k|.

(In reply to Nicholas Nethercote [:njn] from comment #3) > Whoa, that was dubious. Yeah... > I think you can use |key| from above and not create |k|. Oops, thanks! I noticed that at some point but failed to actually fix it. https://hg.mozilla.org/integration/mozilla-inbound/rev/b256487e7f73