Closed Bug 1058270 Opened 10 years ago Closed 10 years ago

Hide the browser icon when a user flashes gaia

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

It looks like we remove the browser app on upgrade, but it may still be installed on a direct install. While we can kill the upgrade code and browser app all together in 2.4, we should make it so that the browser app does not appear for normal builds. To do this we can change the manifest role to be "system".
Attached file Github pull request (deleted) —
Comment on attachment 8478586 [details] Github pull request Hey Guys - I feel like we should land something simple like this to hide the old browser app and get people dogfooding 100%. What do you think?
Attachment #8478586 - Flags: review?(kyle)
Attachment #8478586 - Flags: review?(bfrancis)
Comment on attachment 8478586 [details] Github pull request Sounds fine to me, but I defer to anyone who has more knowledge of system browser than I do, so benfrancis's r+ is the one that matters :)
Attachment #8478586 - Flags: review?(kyle) → review+
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3) > Sounds fine to me, but I defer to anyone who has more knowledge of system > browser than I do, so benfrancis's r+ is the one that matters :) Thanks Kyle. We need to move insanely quickly this week, so I'll probably land with your review and Ben can leave any follow-ups. I've also included a small fix to properly position the new Browser icon. I'll wait for try to be green before landing.
Blocks: 1055688
Comment on attachment 8478586 [details] Github pull request Let's go with Kyle's review for now. Ben - let me know if you have any concerns/follow-ups.
Attachment #8478586 - Flags: review?(bfrancis)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: