I've also fixed the access key for mixed content enable option, as seen in bug 1045809 comment 12 .

Comment on attachment 8488288 [details] [diff] [review] Add access keys for tracking protection doorhanger Review of attachment 8488288 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/browser.dtd @@ +731,5 @@ > <!ENTITY mixedContentBlocked2.options "Options"> > <!ENTITY mixedContentBlocked2.unblock.label "Disable protection for now"> > <!ENTITY mixedContentBlocked2.unblock.accesskey "D"> > <!ENTITY mixedContentBlocked2.block.label "Enable protection"> > +<!ENTITY mixedContentBlocked2.block.accesskey "E"> We don't need to change the entity name here because accesskeys are based off of the related label, but it wouldn't hurt to send an email to the l10n mailing list announcing that mixedContentBlocked2.block.accesskey has changed. @@ +739,5 @@ > <!ENTITY trackingContentBlocked.moreinfo "Parts of the page that track your online activity have been blocked."> > <!ENTITY trackingContentBlocked.learnMore "Learn More"> > <!ENTITY trackingContentBlocked.options "Options"> > <!ENTITY trackingContentBlocked.unblock.label2 "Disable protection for this site"> > +<!ENTITY trackingContentBlocked.unblock.accesskey "D"> Use trackingContentBlocked.unblock.accesskey2 to be consistent with the 'label2' suffix above it.

trackingContentBlocked.unblock.accesskey >>> trackingContentBlocked.unblock.accesskey2 in urlbarbindings.xml and browser.dtd

Comment on attachment 8489472 [details] [diff] [review] Add access keys for tracking protection doorhanger Review of attachment 8489472 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/browser.dtd @@ +739,5 @@ > <!ENTITY trackingContentBlocked.moreinfo "Parts of the page that track your online activity have been blocked."> > <!ENTITY trackingContentBlocked.learnMore "Learn More"> > <!ENTITY trackingContentBlocked.options "Options"> > <!ENTITY trackingContentBlocked.unblock.label2 "Disable protection for this site"> > +<!ENTITY trackingContentBlocked.unblock.accesskey2 "D"> Actually, change trackingContentBlocked.unblock.accesskey2 to trackingContentBlocked.unblock2.accesskey and trackingContentBlocked.unblock.label2 to trackingContentBlocked.unblock2.label so they are consistent and both have a standard suffix.

Can we get a try run for this patch before asking for checkin-needed?

(In reply to Wes Kocher (:KWierso) from comment #6) > Can we get a try run for this patch before asking for checkin-needed? Sorry Wes, you're right. Here is the try run for this patch: https://tbpl.mozilla.org/?tree=Try&rev=e397e01d33fc It looks good to me :-)

I've tested this using FF 35.0b5 and the only modifications I've noticed is that "D" and "E" chars are underlined on Ubuntu and Windows on the "Disable protection for this site" and "Enable protection" strings. Is this what the fix consists of or am I missing something?

Yes, and then pressing D and E while those elements are visible should activate them. You might have to hold Ctrl too, I don't know.

Verified as fixed using: FF 35.0b5 OS: Win 7 x64, Ubuntu 14.04 x64