Closed
Bug 1058650
Opened 10 years ago
Closed 10 years ago
updateBrowserSpecificIndicator should not be called for closed tabs
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
After my fix from bug 1056172, the recording-window-ended notification is also fired for closed tabs, which causes this error: System JS : ERROR resource:///modules/webrtcUI.jsm:753 - TypeError: aBrowser.contentWindow is undefined The attached patch just adds a null check in the code handling the recording-window-ended notification.
Attachment #8479094 -
Flags: review?(gijskruitbosch+bugs)
Comment 1•10 years ago
|
||
Comment on attachment 8479094 [details] [diff] [review] Fix Review of attachment 8479094 [details] [diff] [review]: ----------------------------------------------------------------- It's kind of bizarre that you can go from a content window id to a browser, but not from that browser back to the content window. :-\
Attachment #8479094 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 2•10 years ago
|
||
(make sure you fold this for uplift in bug 1056172 - or uplift both)
Comment 3•10 years ago
|
||
Hi Florian, can you provide a point value and mark the bug as qe-verify+ or qe-verify- for verification.
Iteration: --- → 34.3
Flags: qe-verify?
Flags: needinfo?(florian)
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Points: --- → 1
Flags: qe-verify?
Flags: qe-verify-
Flags: needinfo?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/679ea61dc216
https://hg.mozilla.org/mozilla-central/rev/679ea61dc216
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8479094 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: regression caused by bug 1056172 which I would like to uplift. [User impact if declined]: some JS errors in the browser console when closing a tab with active getUserMedia streams. [Describe test coverage new/current, TBPL]: on m-c. [Risks and why]: low, just adds a nullcheck. [String/UUID change made/needed]: none.
Attachment #8479094 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox34:
--- → fixed
Updated•10 years ago
|
Attachment #8479094 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/27849f3558fa
Updated•10 years ago
|
Whiteboard: [screensharing-uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•