Matthew Miller [:m_and_m] Assignee
	Description • 10 years ago

The application capture engine should provide the window count for each application, for display to the user when selecting which to share.

	Matthew Miller [:m_and_m] Assignee
	Comment 2 • 10 years ago

Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application

This patch uses "\x1e" (Record Separator) to separate the window count from the application name; Some examples:

* "2\x1eFinder"
* "1\x1eSublime Text"
* "3\x1eTerminal"
* "0\x1eVMWare Fusion"

This should be enough to name.split("\x1e") in JavaScript.

	Randell Jesup [:jesup] (needinfo me)
	Comment 3 • 10 years ago

Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application

Review of attachment 8479419 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/modules/desktop_capture/win/desktop_device_info_win.cc
@@ +53,5 @@
>  void DesktopDeviceInfoWin::InitializeApplicationList() {
>    // List all running applications exclude background process.
>    HWND hWnd;
>    for (hWnd = GetWindow(GetDesktopWindow(), GW_CHILD); hWnd; hWnd = GetWindow(hWnd, GW_HWNDNEXT)) {
> +    if (!IsWindowVisible(hWnd)) 

trailing space.  Also, since you're touching it, {} around continue

	Florian Quèze [:florian]
	Comment 4 • 10 years ago

Comment on attachment 8479419 [details] [diff] [review]
Include window count for each application

Works for me (tested only on Mac), thanks! I attached the UI changes that need to land at the same time in bug 1059220.

	Florian Quèze [:florian]
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/5229e47c07b2

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/5229e47c07b2