Closed
Bug 1058902
Opened 10 years ago
Closed 4 years ago
Implement new tablet toolbar editing mode
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mcomella, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
And maybe the animations, if applicable.
Yuan, do we have mocks for what the toolbar should look like after it is pressed (e.g. currently, we hide the toolbar icons and add a close-editing-mode button)? Do we expect to have animations between these states?
Note that this is probably not necessary for new-tablet-v1.
Flags: needinfo?(ywang)
Reporter | ||
Updated•10 years ago
|
Summary: Implement new tablet editing mode → Implement new tablet toolbar editing mode
Comment 1•10 years ago
|
||
Thanks for creating the bug, Michael!
I will work on the design and animations for this. I think we've initially agreed that tablet editing mode/search screen should feel lightweight. Since the tabs are visible on top on tablet, it makes more sense to maintain the state and only change the state inside of the URL bar.
So I am leaning towards Firefox desktop drop-down UI for now. But it might have slight changes while I design for it :)
I will keep you posted!
Flags: needinfo?(ywang)
Reporter | ||
Comment 2•10 years ago
|
||
Yuan, I will probably have time to get to this within the next week or two - do you have any specs?
Note to self: re-enable the options menu on new tablet only (from bug 956858) and de-couple editing mode and those interactions.
Flags: needinfo?(ywang)
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #2)
> Note to self: re-enable the options menu on new tablet only
Or maybe all devices because our "will never use the menu in editing mode" assumptions are all gone.
Comment 4•10 years ago
|
||
Please see attached link for the draft idea I put together for edit mode: http://delivery.yuuuan.com/gb3fcujq
Currently portrait mode only. But I can see this fit into a landscape mode pretty well.
Let's discuss these on Monday's tablet checkin!
Flags: needinfo?(ywang)
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•10 years ago
|
||
We'll be implementing this version of editing mode in at least v2 - see bug 1085596 for v1.
Comment 6•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•