Closed
Bug 1059241
Opened 10 years ago
Closed 10 years ago
array.pop() should not mark the array as non-packed
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jandem, Assigned: jschulte)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
See the testcase below. Ion emits a hole check for the arr[1] load inside the loop, because the arr.pop() call marked the array as non-packed.
This affects deltablue.
function f() {
var res = 0;
var arr = [1, 2, 3];
arr.pop();
for (var i=0; i<1000000; i++) {
res += arr[1];
arr[1] = 1;
}
}
f();
|
Assignee | |
Comment 1•10 years ago
|
||
Nice, 5.6 % improvement on deltablue.
Attachment #8484139 -
Flags: review?(jdemooij)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8484139 [details] [diff] [review]
v1.patch
Review of attachment 8484139 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch. Forwarding to Brian.
Attachment #8484139 -
Flags: review?(jdemooij) → review?(bhackett1024)
|
||
Updated•10 years ago
|
Attachment #8484139 -
Flags: review?(bhackett1024) → review+
|
||
Comment 3•10 years ago
|
||
pushed for johannes on try as he doesn't have L1 commit access:
https://tbpl.mozilla.org/?tree=Try&rev=5d9979000d19
|
|
||
Updated•10 years ago
|
Assignee: nobody → j_schulte
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•