We have 2 failures. Looks like some entities have changed. Test: /testPrivateBrowsing/testAboutPrivateBrowsing.js Failure: getEntity: Entity - privatebrowsingpage.perwindow.issueDesc.normal has been found - got 'null' Test: /testPrivateBrowsing/testOpenClosePBKeyboardShortcut.js Failure: getEntity: Entity - privatebrowsingpage.perwindow.description has been found - got 'null' mc pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dc352a7bf234&tochange=0753f7b93ab7 Bug 1009370 is the regressor.

Here is a report: http://mozmill-daily.blargon7.com/#/functional/report/2f56cb3a3728c2c47cd1b44f77b00b70

Specifically those changes caused the regression on our side: https://hg.mozilla.org/mozilla-central/diff/8f5ad2b5a775/browser/locales/en-US/chrome/browser/aboutPrivateBrowsing.dtd

Quick fix, I updated the DTD entities and the node selectors. I do not like all selectors I had to use, but some elements are lacking proper identification. To improve this we will need to update the about:privatebrowsing page with more relevant hooks (if we deem it important). With the current selectors the tests might break again if the page content gets reordered.

Report with the fix: http://mozmill-crowd.blargon7.com/#/functional/report/2f56cb3a3728c2c47cd1b44f77b2b2b3

Comment on attachment 8479856 [details] [diff] [review] 1.patch Review of attachment 8479856 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Maybe we could get a feedback if they plan to update the pages further?

Comment on attachment 8479856 [details] [diff] [review] 1.patch Review of attachment 8479856 [details] [diff] [review]: ----------------------------------------------------------------- I agree regarding accessibility. Feel free to file new bugs. To get our tests fixed it looks fine to me.

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/5c2689122d12 (default) Thanks Andrei!