Steps to reproduce: While needinfo-ing a mentor here: https://bugzilla.mozilla.org/show_bug.cgi?id=1051221 I ran into an issue that when I selected mentor, the checkbox would be checked and the mentor's name would be filled in the box, but after submitting there was no needinfo to be seen. What should happen: Needinfo the mentor What happened: No needinfo.

Trying it out now!

Ricardo just tried to need-info the mentor for this bug while I was assigned as mentor. That wasn't reflected in this bug and I didn't get an email. Confirming that it's a problem! :)

Help me, Obi-Wan Ricardo, you're my only hope. (This is a test!)

Ok that didnt work either.

This is probably related to some recent refactoring of the bug mentoring field on the back end. I will investigate this further. dkl

Comment on attachment 8480096 [details] [diff] [review] 1059419_1.patch Review of attachment 8480096 [details] [diff] [review]: ----------------------------------------------------------------- putting the mentor into the 'other' field makes that field's behaviour inconsistent. when a bug is first opened, the 'other' field is empted. after selecting reporter/assignee/myself from the needinfo menu and then 'other', it is still empty. however with this patch, if you select a mentor and then 'other', the field is populated with the selected mentor. this shouldn't happen.

resetting the assignedto field due to inactivity. I am not sure if this is still a valid bug, glob could you comment on that?

yes, it's still valid. reassigning back to dkl to put on his radar.

Comment on attachment 8556053 [details] [diff] [review] 1059419_2.patch Review of attachment 8556053 [details] [diff] [review]: ----------------------------------------------------------------- nice; r=glob, with cache=>1 to be fixed on commit. ::: extensions/Needinfo/Extension.pm @@ +121,5 @@ > $requestees{$requestee_obj->login} = 1; > } > } > + # Requestee is a mentor > + elsif ($needinfo_role && Bugzilla::User->check($needinfo_role)) { Bugzilla::User->check do a cached check.. ->check({ name => $needinfo_role, cache => 1 })

Sorry for the delay in fixing this. Should be in production soon. To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git ece0cae..89d3199 master -> master dkl