Closed Bug 1059440 Opened 10 years ago Closed 10 years ago

Don't set noHistory for onboarding activity

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
34 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox34 affected, fennec34+)

Status:
VERIFIED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox34 --- affected
fennec 34+ ---

People

(Reporter: aaronmt, Assigned: liuche)

References

Details

Attachments

(1 file)

Patch: Remove noHistory=true
(deleted), patch
Details | Diff | Splinter Review
Currently, the first-run will be dismissed on either home screen access and then return to the browser, or by opening the recent application listing on the device and then selecting the browser again. -- Nightly (08/27) LG Nexus 5 (Android 4.4.4)
Yuan, what's the desired UX here?
Assignee: nobody → liuche
tracking-fennec: ? → 34+
Flags: needinfo?(ywang)
Thanks for capturing this Aaron. Yes, we should fix these issues. In above cases, the user doesn't take any action to exit the first-run screen and they were not led to the browser by other intent(like a link from another app). So Firefox should maintain its original state, keep the first-run visible.
Flags: needinfo?(ywang)
Summary: First run layout view is dismissed on android application listing access (or via home, and return to the browser) → Don't set noHistory for onboarding activity
Attached patch Patch: Remove noHistory=true (deleted) — — Splinter Review
r=trivial
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 34
https://hg.mozilla.org/mozilla-central/rev/d9099ce2b4ee
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
No longer blocks: firstrun
Depends on: firstrun
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: