Closed Bug 1059528 Opened 10 years ago Closed 10 years ago

programmatically set positioning of the sliding navbar based on text widths

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-10-14

People

(Reporter: kngo, Assigned: julian.mozbugs)

References

Details

Attachments

(2 files)

The navbar is currently hard-coded to slide based on the width of English text. This should change so we detect the width of any of the tabs and slide the appropriate amount.
Blocks: Feed
Depends on: 1059002
Blocks: 1062774
Priority: -- → P4
If it's something that can be done easily and quickly (do I hear you volunteering?) then I'd say yes, but since we're taking a harder look at the nav for reasons like this and others, I'm a little hesitant to spend time fixing this if we're going to completely replace it with something else in short order.
https://github.com/mozilla/fireplace/pull/702 STR: 1. On mobile, go to Marketplace. 2. Play with the navbar in different languages. Expected: Links can always be navigated to as the navbar slides. The link that flows off the screen should have enough room to click. When going to the last link and back, the navbar should slide appropriately. The navbar should never completely cut off the next link. The navbar will sometimes shrink to accommodate long strings. Actual: In different languages, the navbar sometimes overflows. Often, there's not enough room to click the next link.
Status: NEW → RESOLVED
Closed: 10 years ago
Priority: P4 → P2
Resolution: --- → FIXED
Target Milestone: --- → 2014-10-14
Also the swiping behavior has been removed.
Since the swiping behaviour is removed, is it possible to at least scroll horizontally? If not, this means that you deliberately have to click each nav to be able to see the next - which ain't good.
The swiping is impossible to depend upon. Users don't know about it, and FxOS 2.1 has a system-wide swipe gesture. You still had to swipe through the nav one-by-one to see the next nav items. That hasn't changed. Yes, you have to click through the nav to get to the next nav items. This is an inherent part of having a long horizontal nav on a 320px screen. But it's only natural that items on the end of a navigation component will receive less engagement.
Can't you solve this problem with scrolling? That's what horizontal scrolling is for. https://galaxy.dev.mozaws.net/catalogue/ works with scrolling/swiping. You don't have to click or hover over each item to see more. Sorry if I'm being dense - just want to make sure this is an improvement. Thanks for fixing this bug BTW.
Hm, adding scrolling might be an improvement. I am not sure how well that will work on devices though given it's a small scroll target; users might accidentally scroll when trying to click or click when trying to scroll. I might give it a shot sometimes, but I'm sure what's here is an improvement.
Attached image feedback_link.png (deleted) —
The issue is still reproducing for the Feedback link in https://marketplace.allizom.org/settings on FF35 (Win 7) and MP-stage app (Inari 1.4). Please see attached screenshot.
Assignee: nobody → iulian.timis
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Per comment 7, even though this fixes the case for non-English locales, this actually complicates the interface more. I have to keep clicking each link to see more. That causes unnecessary clicks and requests. And it is probably not intuitive to most users. I figured it out, but I think I'm an exception. And the borders have become wider, which look weird: https://www.dropbox.com/s/37mkkhz1s7uywe6/Screenshot%202014-10-15%2000.57.42.png?dl=0 For things to look correct (and increase the click area), you should instead add another element in the `<a>` so you can just add padding to the `<a>`.
Iulian, it's currently expected to be cut-off. There will be further changes to improve that. Chris, it actually doesn't complicate it more since you still have to click through each link before. And as for now, every link is visible. Although it stills sucks.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Btw, even with overflow scrolling, things will still be cut off. Unless you add an indicator it can scroll (a quick animation or a fade on the edge of the screen).
Verified as fixed in https://marketplace.allizom.org/ on FF36 (Win 7) and MP-stage app (Inari). Attaching postfix screenshot. Closing bug.
Status: RESOLVED → VERIFIED
Attached image postfix_navbar.png (deleted) —
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: