Closed
Bug 1059557
Opened 10 years ago
Closed 10 years ago
css animated throbber causes heavy cpu load
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
People
(Reporter: jrmuizel, Assigned: jaws)
References
Details
(Keywords: perf)
We have much higher cpu load from this animation with limited benefit. This animation seems to cause high cpu load even when the throbber is not visible.
Comment 1•10 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> We have much higher cpu load from this animation with limited benefit. This
> animation seems to cause high cpu load even when the throbber is not visible.
This would be bug 962594, which we worked around in bug 1016942. So this shouldn't be happening anymore...
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2)
> Jeff, is comment 1 wrong?
Yes. I still have high load when non-visible tabs have a spinning throbber. The load is also especially high when the tabs are still visible? Is there a performance comparison somewhere to the previous animated png throbber? I see 39% Nightly cpu usage and 46% WindowServer usage with a visible throbber. Is this expected?
Flags: needinfo?(jmuizelaar)
Comment 4•10 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> (In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2)
> > Jeff, is comment 1 wrong?
>
> Yes. I still have high load when non-visible tabs have a spinning throbber.
You mean tabs that are scrolled off-screen? Would the png throbber stop animating and straining the CPU in that case?
> The load is also especially high when the tabs are still visible? Is there a
> performance comparison somewhere to the previous animated png throbber? I
> see 39% Nightly cpu usage and 46% WindowServer usage with a visible
> throbber. Is this expected?
That's to some extent expected, as the png throbber has a lower frame rate. The CSS animation is expected to be smoother. Another expectation is that off-main-thread animations will alleviate the performance impact.
Reporter | ||
Comment 5•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > (In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2)
> > > Jeff, is comment 1 wrong?
> >
> > Yes. I still have high load when non-visible tabs have a spinning throbber.
>
> You mean tabs that are scrolled off-screen? Would the png throbber stop
> animating and straining the CPU in that case?
I'm not sure. I never noticed cpu load from the png throbbers though.
> > The load is also especially high when the tabs are still visible? Is there a
> > performance comparison somewhere to the previous animated png throbber? I
> > see 39% Nightly cpu usage and 46% WindowServer usage with a visible
> > throbber. Is this expected?
>
> That's to some extent expected, as the png throbber has a lower frame rate.
> The CSS animation is expected to be smoother. Another expectation is that
> off-main-thread animations will alleviate the performance impact.
We don't have off-main-thread animations on right now. I expect it might be worth waiting till then before enabling the css-animation.
Comment 6•10 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> We don't have off-main-thread animations on right now. I expect it might be
> worth waiting till then before enabling the css-animation.
We've been backing out the CSS throbber from Firefox 32 and 33 and we should probably keep doing that until off-main-thread animations are enabled.
Comment 7•10 years ago
|
||
[Tracking Requested - why for this release]: see comment 6
Blocks: 759252
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
tracking-firefox34:
--- → ?
tracking-firefox35:
--- → ?
Component: Toolbars and Customization → Theme
Depends on: enable-omt-animations
Keywords: perf
OS: Mac OS X → All
Hardware: x86 → All
Comment 8•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #6)
> We've been backing out the CSS throbber from Firefox 32 and 33 and we should
> probably keep doing that until off-main-thread animations are enabled.
+1 Can we back out the CSS throbber altogether and reland the it after OMTC animations land?
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(dao)
Assignee | ||
Comment 9•10 years ago
|
||
Yeah, I agree, we should just back out. It doesn't appear that OMTC will be enabled on Windows Nightly for quite a few releases still (please correct me if I'm wrong).
Reporter | ||
Comment 10•10 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> Yeah, I agree, we should just back out. It doesn't appear that OMTC will be
> enabled on Windows Nightly for quite a few releases still (please correct me
> if I'm wrong).
This needs Off Main Thread Animations not just OMTC. OMTC will hopefully be in the upcoming release.
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> > Yeah, I agree, we should just back out. It doesn't appear that OMTC will be
> > enabled on Windows Nightly for quite a few releases still (please correct me
> > if I'm wrong).
>
> This needs Off Main Thread Animations not just OMTC. OMTC will hopefully be
> in the upcoming release.
Sorry and thanks for the clarification.
Comment 12•10 years ago
|
||
Flags: needinfo?(dao)
Comment 13•10 years ago
|
||
Assignee: nobody → jaws
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 35.3
Points: --- → 1
Updated•10 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Comment 14•10 years ago
|
||
jaws - 34 is marked as affected. Can you please submit an Aurora uplift request?
Flags: needinfo?(jaws)
Comment 15•10 years ago
|
||
Erm, rather, can you back this out of 34 as I see it has been backed out of 32, 33, and 35?
Comment 16•10 years ago
|
||
This was backed out in bug 1016434.
This was verified in bug 1016434.
Flags: qe-verify?
Flags: qe-verify-
Flags: needinfo?(jaws)
You need to log in
before you can comment on or make changes to this bug.
Description
•