Closed
Bug 1059833
Opened 10 years ago
Closed 10 years ago
[gaia-header] Button transition-delays should only impact touch/user interaction
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | fixed |
People
(Reporter: wilsonpage, Assigned: wilsonpage)
References
Details
Attachments
(2 files)
Currently gaia-header is applying a transition-delay to *all* button state changes, meaning property changes due to buttons being disabled (eg. opacity) are also delayed. This is not as desired.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wilsonpage
Assignee | ||
Updated•10 years ago
|
Component: Gaia::Components → Gaia
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8480752 -
Flags: review?(kyee)
Assignee | ||
Updated•10 years ago
|
Attachment #8480747 -
Flags: review?(yor)
Assignee | ||
Updated•10 years ago
|
Attachment #8480752 -
Flags: review?(yor)
Comment on attachment 8480752 [details]
pull-request (gaia:master)
It looks like min-active is being applied to gaia-header, but it doesn't look like the style is being applied to the buttons. Not sure why this is since i do see that there are selectors within the stylesheets for this.
Attachment #8480752 -
Flags: review?(kyee) → review-
I tried it on the Contacts app but I'm not sure I can really tell the delayed transition as pressing a button always causes a screen transition. We certainly don't see the unwanted delayed transition on things like button enable/disable anymore.
Przemek, Is there a specific app you know of where the header buttons interaction is visually affected by the transition delay?
Flags: needinfo?(pabratowski)
Attachment #8480747 -
Flags: review?(kyee)
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Yan Or from comment #5) > Przemek, > > Is there a specific app you know of where the header buttons interaction is > visually affected by the transition delay? All :active states should appear delayed all buttons in the gaia-header.
Flags: needinfo?(pabratowski)
Assignee | ||
Comment 7•10 years ago
|
||
The intention here is that the user still sees visual feedback (:active styling) when a button is tapped quickly.
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Casey Yee [:cyee] from comment #3) > Comment on attachment 8480752 [details] > pull-request (gaia:master) > > It looks like min-active is being applied to gaia-header, but it doesn't > look like the style is being applied to the buttons. Not sure why this is > since i do see that there are selectors within the stylesheets for this. If you are trying this is the gaia-header example page you won't see any transition delay as this is defined by the `--header-button-transition-delay` variable in gaia-theme. You'd have to test in an app, or with the gaia-theme present.
Assignee | ||
Updated•10 years ago
|
Attachment #8480752 -
Flags: review- → review?(gmarty)
Assignee | ||
Updated•10 years ago
|
Attachment #8480747 -
Flags: review?(gmarty)
Attachment #8480752 -
Flags: review?(yor) → review+
Attachment #8480747 -
Flags: review?(yor) → review+
Comment 9•10 years ago
|
||
Comment on attachment 8480752 [details]
pull-request (gaia:master)
Looks nice.
Attachment #8480752 -
Flags: review?(gmarty) → review+
Updated•10 years ago
|
Attachment #8480747 -
Flags: review?(gmarty) → review+
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Blocks: gaia-header
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8480747 [details] pull-request (gaia-header:master) LANDED https://github.com/wilsonpage/gaia-header/commit/f8854e661e78d0b833f86716c8cb4836c6362c5d
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Stephany Wilkes from comment #11) > Wilson you are our hero! Woah, not landed on Gaia yet, just in gaia-header repo :(
Assignee | ||
Comment 13•10 years ago
|
||
I stamped gaia-header v0.3.11 [1] which includes the new JS driven `:active` approach to give us full control over our 'pressed' state styling. I have updated Gaia to use this new version, so someone just has to push the button and land it once we have green gaia-try. [1] https://github.com/gaia-components/gaia-header/releases/tag/v0.3.11
Status: NEW → ASSIGNED
Comment 14•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/fd719f6fd74d74d88314429a07de68c655552609
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•