Marcia Knous [:marcia] Reporter
	Description • 10 years ago

Flame, while running:

Gaia   3a838afca295c9db32e1a3ec76d49fb7fe7fd2d2
SourceStamp 3be45b58fc47
BuildID 20140828040204
Version 34.0a1
Base Image: v123


1. Launch some sites from the rockebar, specifically typing the full URLs
2. After the site loads, go back to the rocketbar
3. Receive the attached screenshot

Adding qawanted to see if we can better STR.

	Pi Wei Cheng [:piwei] (inactive)
	Comment 1 • 10 years ago

Possibly dupe of bug 1057448

To repro this bug 1059842 is very similar to bug 1057448.

STR:
1) Access any website in Browser
2) Kill Browser process by long pressing Home button and swipe the process up
3) Open Browser again - notice that Top Sites UI is displayed
4) Tap on top left corner of screen to bring up the Rocket Bar search
5) Type in 'social' or any search term
6) Once results are populated, tap on top left corner of screen again

Observed behavior: Screenshot from comment 0 is displayed.

	Marcia Knous [:marcia] Reporter
	Comment 2 • 10 years ago

[Blocking Requested - why for this release]: Bad user experience. Tapping in the space above the Rocketbar should dismiss the results.

I have a better set of Steps for this bug, and I think it is different than the bug cited in Comment 1 (in the video it is hard to tell what operation is being done after moving away from the Rocketbar)

STR:

1. Start typing in the Rocketbar from the Homescreen
2. While still focused, tap in the space above the Rocketbar
3. You are taken back to the homescreen and the search results overlap everything on the homescreen.

Moving this to search, but it basically happens in any app where you have previously typed in the Rocketbar and then tapped above it.

	Joshua Mitchell (Inactive)
	Comment 3 • 10 years ago

Marcia - just curious if you saw comment 1 - do you feel like this is a separate issue?

	Marcia Knous [:marcia] Reporter
	Comment 4 • 10 years ago

(In reply to Joshua Mitchell [:Joshua_M] from comment #3)
> Marcia - just curious if you saw comment 1 - do you feel like this is a
> separate issue?

I don't know if it is, but I think the explanation in this bug is more clear. In the video in the other bug I cannot tell what is being selected after text is typed in the bar and we are using terminology that isn't clear. I will comment in that bug as well.

	Kevin Grandon :kgrandon
	Comment 6 • 10 years ago

Comment on attachment 8482521 [details]
Pull request

Thank you for digging into this! Could you by chance add a unit test for this?

	Sherman Chen [:chens] (inactive) Assignee
	Comment 7 • 10 years ago

Sure, I will try to add unit test later.

	Sherman Chen [:chens] (inactive) Assignee
	Comment 8 • 10 years ago

Add unit test and update pull request: 
https://github.com/mozilla-b2g/gaia/pull/23610

	Kevin Grandon :kgrandon
	Comment 9 • 10 years ago

Nice tests, thanks! In master: https://github.com/mozilla-b2g/gaia/commit/271c527d57c845e0c38b42deed91e8a89a137f1a

	Kevin Grandon :kgrandon
	Comment 10 • 10 years ago

I've reverted the original landing due to an incorrect bug number in the commit. Improper bug numbers in commits make it difficult to track down history and find the proper bug where something was implemented.

Reverted: https://github.com/mozilla-b2g/gaia/commit/55088260f17e3417709041c498ad81e60308924a

Re-landed at: https://github.com/mozilla-b2g/gaia/commit/161fd117eff1d3c647260a671bab2fbe75b40e7c

	Kevin Grandon :kgrandon
	Comment 11 • 10 years ago

Comment on attachment 8483021 [details]
Github commit

This is required for a blocker (bug 1057448), and is a pretty terrible user experience. We should uplift this to 2.1.

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/4e52cada8800563722b071cc3806da446940ccf4

	John Thomas [:Johnt]
	Comment 13 • 10 years ago

This issue is verfied fixed for the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Icons no longer appear on topsites.