Closed
Bug 1059899
Opened 10 years ago
Closed 10 years ago
Allow an AudioCallbackDriver to fallback to a SystemClockDriver when opening a stream fails
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | unaffected |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jesup
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
Sound won't work, but at least tests won't fail
Assignee | ||
Comment 1•10 years ago
|
||
This will fix 1059258 and maybe other intermittents, most of the time on
Windows 7 (not 8, not vista, 7 only, because of what seems to be a windows bug).
This brings back the behaviour of the pre-refactoring MSG, in case of
cubeb_stream_init failure: sound will not be output, but everything else will
continue working (AnalyserNode, ScriptProcessorNode, video, etc.). This is
absolutely edge-casey (apparently it can be reproed when creating 200 <audio>
and trying to create an AudioContext right after on certain version of windows
7).
Also, tests will be shown as green, because there is little we can do against os
bugs.
Attachment #8487160 -
Flags: review?(rjesup)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → paul
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Updated•10 years ago
|
Attachment #8487160 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Updated•10 years ago
|
Comment 4•10 years ago
|
||
Comment on attachment 8487160 [details] [diff] [review]
When cubeb_stream_init fails, fallback to using a SystemClockDriver. r=
Approval Request Comment
[Feature/regressing bug #]: Bug 848954
[User impact if declined]: Intermittents on Windows; lockups/failures in odd timing edgecases
[Describe test coverage new/current, TBPL]: Covered which is why we see the intermittent. On inbound.
[Risks and why]: low risk - we don't want to simply fail to start a driver when we need one.
[String/UUID change made/needed]: none
Attachment #8487160 -
Flags: approval-mozilla-aurora?
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 6•10 years ago
|
||
Comment on attachment 8487160 [details] [diff] [review]
When cubeb_stream_init fails, fallback to using a SystemClockDriver. r=
Aurora+
Attachment #8487160 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
status-firefox32:
--- → unaffected
status-firefox33:
--- → unaffected
Updated•10 years ago
|
Comment 7•10 years ago
|
||
Updated•10 years ago
|
Whiteboard: [webrtc-uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•