Closed Bug 1060121 Opened 10 years ago Closed 10 years ago

Make WebGLContext::TexImage2D avoid readback for video elements on Windows

Categories

(Core :: Graphics: CanvasWebGL, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: chiajung, Assigned: chiajung)

References

Details

Attachments

(1 file, 1 obsolete file)

This is a follow up bug for bug 814524. In bug 814524, we provided a shader for convert video frames in GPU and make things faster, however, the shader there do not work on Windows platform.
Attached patch V1 (obsolete) (deleted) — Splinter Review
Attachment #8480946 - Flags: review?(jgilbert)
Comment on attachment 8480946 [details] [diff] [review] V1 Review of attachment 8480946 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLBlitHelper.cpp @@ +182,5 @@ > GLBlitHelper::InitTexQuadProgram(BlitType target) > { > const char kTexBlit_VertShaderSource[] = "\ > + #ifdef GL_ES \n\ > + precision mediump float; \n\ Don't indent the contents of ifdefs, generally.
Attachment #8480946 - Flags: review?(jgilbert) → review+
Comment on attachment 8480946 [details] [diff] [review] V1 Review of attachment 8480946 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, I will push to try later. ::: gfx/gl/GLBlitHelper.cpp @@ +182,5 @@ > GLBlitHelper::InitTexQuadProgram(BlitType target) > { > const char kTexBlit_VertShaderSource[] = "\ > + #ifdef GL_ES \n\ > + precision mediump float; \n\ Other shaders in this file indent in this style. I just follow them. Should I fix all the indent in this file?
By the way, I find some nit in the patch of Bug 814524. May I carry the fix here?
Attached patch V1, final (deleted) — Splinter Review
Add review info, carry r+.
Attachment #8480946 - Attachment is obsolete: true
Attachment #8482073 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: