Closed
Bug 1060174
Opened 10 years ago
Closed 10 years ago
[SETTINGS] Launch the Privacy Panel from Settings App
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(feature-b2g:2.2+)
RESOLVED
FIXED
feature-b2g | 2.2+ |
People
(Reporter: marta, Assigned: daniel.marecik)
References
Details
(Keywords: privacy)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-github-pull-request
|
Details |
Add a button to SettingsApp that lounches the PP, and a back button to PP main screen
Summary: Launch the Privacy Panel from Settings App → [SETTINGS] Launch the Privacy Panel from Settings App
QA Whiteboard: STATUS: engineering design → STATUS: not started
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/developer.js
Sample code that launches the First Time Use app from the settings.
What should be done:
1. Implement a button in Settings App and connect the js file like the one above that launches the PP.
2. Implement a back button in PP, and connect the js file that looks like one above but launches settings.
QA Whiteboard: STATUS: not started → STATUS: implementation work
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Button in Settings App and js file were added.
Back button in PP and js file were added.
At the moment back button is always displayed. Finally the button should be displayed only, when PP is opened from Settings App.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8487000 -
Attachment is obsolete: true
QA Whiteboard: STATUS: implementation work → STATUS: ready for review
Priority: P3 → --
Comment 5•10 years ago
|
||
I know it's a hack, but in theory we could use the settings db to indicate when the PP is launched from settings. Here's how:
0. The settings app creates/sets a settings db key-value-pair like: privacy_panel.launched_from = settings.
1. The privacy panel app always checks for and clears the privacy_panel.launched_from settings db value when it starts up.
2. If the settings db value is "settings" then the back button is shown. Otherwise, it is hidden.
The end result is that the back button will be shown whenever the settings app launches the privacy panel. if the privacy panel is launched from the home screen the settings db key-value-pair will not be set and the back button won't be shown.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
feature-b2g: --- → 2.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•