Closed
Bug 1060177
Opened 10 years ago
Closed 10 years ago
[ALA] Grid Algorithm
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(feature-b2g:2.2+)
RESOLVED
FIXED
feature-b2g | 2.2+ |
People
(Reporter: marta, Assigned: agnieszka.baranowska)
References
Details
(Keywords: privacy)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/plain
|
Details |
In order to have ALA we need to implement a grid algorithm that will return the middle of a cell in which the user is.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Please see attachment Bug1060177.patch which delivers grid algorithm.
Assignee | ||
Comment 3•10 years ago
|
||
QA Whiteboard: STATUS: Patch Landed → STATUS: waiting for review
Comment 4•10 years ago
|
||
Comment on attachment 8483466 [details]
https://github.com/mozilla/gecko-dev/pull/46
gecko-dev can't accept pull requests unfortunately, however the patch you've also attached here is the correct format to submit work to this project :-)
Attachment #8483466 -
Attachment is obsolete: true
QA Whiteboard: STATUS: waiting for review → STATUS: ready for review
Comment 5•10 years ago
|
||
Can you please reformat this patch into the mercurial format? In your .gitconfig add this:
[alias]
hgpatch = show --binary --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8
Then run 'git hgpatch' to create the patch file.
Thanks!
Flags: needinfo?(agnieszka.baranowska)
Assignee | ||
Comment 6•10 years ago
|
||
Flags: needinfo?(agnieszka.baranowska)
Assignee | ||
Comment 7•10 years ago
|
||
HG patch created
Comment 8•10 years ago
|
||
One last little detail. You should have just named the new patch file Bug1060177.patch and when you attached it, there is a checkbox that says, "this attachment obsoletes: <dropdown box>" You should have said that the new patch file obsoletes the previous patch file. That way there would only be a single attachment and it would be the latest, properly formatted patch.
:)
Flags: needinfo?(agnieszka.baranowska)
Assignee | ||
Comment 9•10 years ago
|
||
Ok, I will remember about it next time.
Flags: needinfo?(agnieszka.baranowska)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
feature-b2g: --- → 2.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•