Closed
Bug 1060385
Opened 10 years ago
Closed 10 years ago
[shared/pages/import] Implement gaia-header
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wilsonpage, Assigned: wilsonpage)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
The shared/pages/import app needs to migrate from deprecated header building-block to gaia-header web-component.
Assignee | ||
Comment 2•10 years ago
|
||
francisco: I haven't had chance to test this patch on device as I wasn't sure how to launch it. It's a pretty simple patch though.
Assignee | ||
Updated•10 years ago
|
Blocks: gaia-header
Comment 3•10 years ago
|
||
Thank you, Wilson. If we can get review on this on Monday (a holiday in U.S. and Canada) it should still be able to make FL.
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/b98e39c32a7049dd8054b34bff9edb14b215267d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
Comment on attachment 8481324 [details]
pull-request (master)
Not happy with the way this has been merged, no review, with gaia-try totally busted.
But ... at least the code looks good to me.
Thanks folks for the work here.
Attachment #8481324 -
Flags: review?(francisco)
You need to log in
before you can comment on or make changes to this bug.
Description
•