Closed Bug 1060693 Opened 10 years ago Closed 10 years ago

SHB shows up when opening a game

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: gwagner, Assigned: etienne)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

(deleted), text/x-github-pull-request
alive
: review+
Details
On Flame device with current trunk. Open games smart collection. Click for example on simon says. Software Home Button shows up for a few seconds even when its disabled.
Eli, can you take a look here?
Assignee: nobody → eperelman
Whiteboard: [systemsfe]
got a fix, stealing
Assignee: eperelman → etienne
Attached file Gaia PR (deleted) —
Attachment #8482165 - Flags: review?(alive)
For wrapper, e.me stuff and all, the isFullScreen() appWindow method returns |undefined| since we have no manifest. But now we're using this result to do a classList.toggle('', bool), and since the second param is undefined we actually display the SHB once out of twice :)
Blocks: 1054126
Comment on attachment 8482165 [details] Gaia PR Not sure if we have better way to replace the long statement to generate the boolean..but r+ still.
Attachment #8482165 - Flags: review?(alive) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
The issue is verified fixed in Flame 2.1 and Flame 2.2: Flame 2.1 KitKat Base (319mb)(Full Flash) Environmental Variables: Device: Flame 2.1 BuildID: 20141008000201 Gaia: d71f8804d7229f4b354259d5d8543c25b4796064 Gecko: 7fa82c9acdf2 Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Flame 2.2 KitKat Base (319mb)(Full Flash) Environmental Variables: Device: Flame 2.2 Master BuildID: 20141008040203 Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71 Gecko: e4cfacb76830 Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 The SHB did not appear when opening a game while it was disabled.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: