Alice0775 White Reporter
	Description • 10 years ago

Steps To Reproduce:
1. Open newTab(setting blank) with clicking + icon or Ctrl+T
2. Repeat step 1

Actual Results:
引っかかる

	Alice0775 White Reporter
	Comment 1 • 10 years ago

[Tracking Requested - why for this release]:

Oops, accidentally send


Actual Results:
slow(lagged)

WORKAROUND
intl.tsf.enable = false helps


Regression window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/25bf2f1664e9
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140804130425
Bad:
https://hg.mozilla.org/mozilla-central/rev/7f81be7db528
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140804131527
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=25bf2f1664e9&tochange=7f81be7db528

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca6da63f025
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140803183130
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad532252ff9e
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140803183229

Regressed by: 
ad532252ff9e	Masayuki Nakano — Bug 1037328 Enable TSF mode in default settings of Nightly builds r=jimm+emk+m_kato

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 2 • 10 years ago

Are you really sure that the performance is actually slower. I mean that it might be the problem of refreshing rate. I guess that when location bar gets focus, TSF perhaps queries its content and it causes flushing pending layout.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 3 • 10 years ago

Um, I don't feel this is actually a problem in usual use cases. My environment is Win8.1 with ATOK 2014. How about you?

	Alice0775 White Reporter
	Comment 4 • 10 years ago

Win8.1 + MS IME2012.
This is very small lag(0.3-0.5sec).  
So, This is enough to mark INVALID.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 5 • 10 years ago

According to this log, GetTextExt() should cause flushing layout before retrieving the caret position because if layout is still pending, it returns wrong position to the TIP (ATOK 2014).

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 6 • 10 years ago

(In reply to Alice0775 White from comment #4)
> So, This is enough to mark INVALID.

Okay, but I keep this bug in mind and if I found an idea to improve this, I'd try to fix this.

	Alice0775 White Reporter
	Comment 7 • 10 years ago

Aha, I found the laggy is for switching tab!

Tested on win8.1(VMWare player) + MSIME 2012

Steps To Reproduce:
1. Open 2 tab i.e., [about:home] [about:home] 
2. Switch tab between them

Actual Results:
The lag is noticeable if TSF enabled

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 8 • 10 years ago

This bug shouldn't block any release because TSF mode is enabled only on Nightly.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 9 • 9 years ago

Hmm, I don't feel slow with the STR in comment 7. Do you have some other STRs?

	Alice0775 White Reporter
	Comment 10 • 9 years ago

I am not sure but it seems to be depended on CPU power...


Another Steps To Reproduce:
1. Open 4-8 tab i.e., [about:home] [about:home] ...
2. Switch tab between them, i.e., press Ctrl+TAB and hold

Actual Results:
Laggy or
Tab would not be switched until key up.

Expected results:
While you hold down the Ctrl+TAB key, the tabs should be switched sequentially.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 11 • 9 years ago

(In reply to Alice0775 White from comment #10)
> I am not sure but it seems to be depended on CPU power...
> 
> 
> Another Steps To Reproduce:
> 1. Open 4-8 tab i.e., [about:home] [about:home] ...
> 2. Switch tab between them, i.e., press Ctrl+TAB and hold
> 
> Actual Results:
> Laggy or
> Tab would not be switched until key up.

I think that each symptoms may be caused by other bugs...

> Expected results:
> While you hold down the Ctrl+TAB key, the tabs should be switched
> sequentially.

Works fine to me with either MS-IME or ATOK 2015 on Windows 8.1.


Hi, guys, do you reproduce this bug on your environment?

	Makoto Kato [:m_kato]
	Comment 12 • 9 years ago

I cannot reproduce this on Windows 8.1 + Microsoft IME + Nightly.

- Step
1. Open about:home on 8 tabs
2. Switch tab by ctrl+tab

- Result
I can switch tab quickly.  Although I repeat step 2, I cannot reproduce...

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 13 • 9 years ago

Thank you, Kato-san. I think that this shouldn't block to enable TSF mode in release build until somebody finds the exact conditions and/or bottleneck of the performance from profile or something.

Alice-san, if you can profile it, let us know the result.
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler