+++ This bug was initially created as a clone of Bug #1049195 +++ During investigating Bug 1049195, I recognized that glFush()/glFinish() works to reduce kgls memory usage. But on memory-pressure, glFlush() is not called to SkiaGL's GLContext.

[Blocking Requested - why for this release]: Blocking 2.0+ bugs.

Comment on attachment 8481780 [details] [diff] [review] patch - Call glFlush() to SkiaGL's GLContext on memory-pressure Review of attachment 8481780 [details] [diff] [review]: ----------------------------------------------------------------- Why not call GrContext::flush()?

(In reply to George Wright (:gw280 PTO Aug 15th - 24th) from comment #3) > Comment on attachment 8481780 [details] [diff] [review] > patch - Call glFlush() to SkiaGL's GLContext on memory-pressure > > Review of attachment 8481780 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why not call GrContext::flush()? GrContext::flush() is called in GrContext::freeGpuResources(). But GrContext::flush() does not call glFlush(). http://mxr.mozilla.org/mozilla-central/source/gfx/skia/trunk/src/gpu/GrContext.cpp#216

GrContext::flush() calls GrInOrderDrawBuffer::flush(). http://mxr.mozilla.org/mozilla-central/source/gfx/skia/trunk/src/gpu/GrInOrderDrawBuffer.cpp#556

(In reply to Sotaro Ikeda [:sotaro] from comment #5) > GrContext::flush() calls GrInOrderDrawBuffer::flush(). > http://mxr.mozilla.org/mozilla-central/source/gfx/skia/trunk/src/gpu/ > GrInOrderDrawBuffer.cpp#556 GrInOrderDrawBuffer::flush() does not call glFlush().

Comment on attachment 8481780 [details] [diff] [review] patch - Call glFlush() to SkiaGL's GLContext on memory-pressure Review of attachment 8481780 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine then, but please add a comment about the flush call to say that GrContext::flush() doesn't call glFlush.

Apply the comment.

Note that due to recent policy changes, all B2G uplifts needs approval now regardless of blocking status. Please request aurora and b2g32 approval on this patch when you get a chance. Sorry for the inconvenience.

Comment on attachment 8482944 [details] [diff] [review] patch - Call glFlush() to SkiaGL's GLContext on memory-pressure r=gw280 NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): None. User impact if declined: An application might be killed more than the fix is applied. Testing completed: Tested locally on flame device. Risk to taking this patch (and alternatives if risky): Low. String or UUID changes made by this patch:

(In reply to Sotaro Ikeda [:sotaro] from comment #13) > > [Approval Request Comment] > Bug caused by (feature/regressing bug #): None. > User impact if declined: An application might be killed more than the fix is > applied. An application might be killed more than the fix is applied because of low memory.

https://hg.mozilla.org/releases/mozilla-aurora/rev/a5d0c86dca93 https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/b4f4f0423815