Closed
Bug 1060973
Opened 10 years ago
Closed 10 years ago
Fix more bad implicit constructors in XPCOM
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8481987 -
Flags: review?(nfroyd)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8481987 [details] [diff] [review]
Fix more bad implicit constructors in XPCOM
Review of attachment 8481987 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/glue/pldhash.h
@@ +278,5 @@
> * builds, attempting to do so will result in an assertion failure.
> */
> class Iterator {
> public:
> + explicit Iterator(const PLDHashTable* aTable);
Argh, I should have caught this.
Attachment #8481987 -
Flags: review?(nfroyd) → review+
|
||
Comment 3•10 years ago
|
||
(In reply to Nathan Froyd (:froydnj) from comment #2)
> Argh, I should have caught this.
Don't feel bad, checking tedious things like this is what static analysis is for.
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•