Closed
Bug 1061009
Opened 10 years ago
Closed 10 years ago
Fix more bad implicit constructors in a11y
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8482015 -
Flags: review?(trev.saunders)
|
||
Updated•10 years ago
|
Attachment #8482015 -
Flags: review?(trev.saunders) → review+
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8482015 [details] [diff] [review]
Fix more bad implicit constructors in a11y
> class xpcAccessibleTable
> {
> public:
>- xpcAccessibleTable(mozilla::a11y::TableAccessible* aTable) : mTable(aTable) { }
>+ explicit xpcAccessibleTable(mozilla::a11y::TableAccessible* aTable) : mTable(aTable) { }
really long line, please break it.
>+++ b/accessible/xpcom/xpcAccessibleTableCell.h
>@@ -20,17 +20,17 @@ class TableCellAccessible;
>
> /**
> * This class provides an implementation of the nsIAccessibleTableCell
> * interface's methods.
> */
> class xpcAccessibleTableCell
> {
> public:
>- xpcAccessibleTableCell(mozilla::a11y::TableCellAccessible* aTableCell) :
>+ explicit xpcAccessibleTableCell(mozilla::a11y::TableCellAccessible* aTableCell) :
> mTableCell(aTableCell) { }
same
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
|
Assignee | |
Comment 4•10 years ago
|
||
I'm sorry, I didn't see the review comments... Addressed them here: https://hg.mozilla.org/integration/mozilla-inbound/rev/8916e598fa3f
|
|
||
Comment 5•10 years ago
|
||
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•