Philip K. Warren Reporter
	Description • 23 years ago

There are problems in the current xptcinvoke code with the way it handles
passing floating point parameters. This is clearly shown in the output of
TestXPTCInvoke program:

calling direct:
        1 + 1 = 2
        1L + 1L = 2
        2 * 2 = 4
        2L * 2L = 4
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000f
calling via invoke:
        1 + 1 = 2
        1L + 1L = 2
        2 * 2 = 4
        2L * 2L = 4
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 =
-11885959257070703919456148548600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.000000
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = -INFf

The problem lies in the assembly code (xptcinvoke_asm_ppc_aix.s), where the
argument "fprData" is prepared in register 6 for the call to
invoke_copy_to_stack, however it is unused (not even shown as a parameter) in
the invoke_copy_to_stack function. I have attached a patch to resolve this
problem. Here is the output of TestXPTCInvoke after the patch is applied:

calling direct:
        1 + 1 = 2
        1L + 1L = 2
        2 * 2 = 4
        2L * 2L = 4
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000f
calling via invoke:
        1 + 1 = 2
        1L + 1L = 2
        2 * 2 = 4
        2L * 2L = 4
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000
        1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 = 55.000000f

This patch also fixes the ability to Increase/Decrease the font size which was
previously broken on AIX.

	Bradley Baetz (:bbaetz)
	Comment 2 • 23 years ago

-> xpconnect

	David Bradley
	Comment 3 • 23 years ago

Adding jdunn, since he's the one that originally created this code.

	Jim Dunn Assignee
	Comment 4 • 23 years ago

accepting

	David Bradley
	Comment 5 • 23 years ago

jdunn, since you're accepting this I'm going to formally assign this to. If
that's no ok just hand it back, thanks.

	Jim Dunn Assignee
	Comment 6 • 23 years ago

cc'ing cls, hoping to get a r= out of him.
CLS, this is AIX only!

	hacker formerly known as seawood@netscape.com
	Comment 7 • 23 years ago

Comment on attachment 54559 [details] [diff] [review]
fixes floating point problem with xptcinvoke on AIX

r=cls

	Jim Dunn Assignee
	Comment 8 • 23 years ago

fix checked in

	Phil Schwartau
	Comment 9 • 23 years ago

Check-in verified. I don't have knowledge of the TestXPTCInvoke program,
nor the AIX platform to test on. 
                                                                                      
pkw@austin.ibm.com: if you don't mind, can you add a comment to this bug
verifying that this fixed the problem? Thanks - 

	Philip K. Warren Reporter
	Comment 10 • 23 years ago

It looks good from here.

	Christopher Blizzard (:blizzard)
	Comment 11 • 23 years ago

Has this been checked into the 0.9.6 branch yet?

	Christopher Blizzard (:blizzard)
	Comment 12 • 23 years ago

hrm, nevermind, it appears so.