Closed
Bug 1061384
Opened 10 years ago
Closed 10 years ago
Swap the Gingerbread orange on share selection with something modern
Categories
(Firefox for Android Graveyard :: Overlays, defect)
Tracking
(firefox34 wontfix, firefox35 verified, firefox36 verified)
VERIFIED
FIXED
Firefox 35
People
(Reporter: aaronmt, Assigned: ckitching)
References
Details
(Whiteboard: [war-on-orange])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
rnewman
:
review+
lmandel
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
screenshot.png
No description provided.
|
||
Comment 1•10 years ago
|
||
Just talked to Yuan, on select let's use #F5F5F5 :)
|
|
||
Comment 2•10 years ago
|
||
Also wanted to add, by default it should be #EBEBF0 as the background color.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → chriskitching
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://www.dropbox.com/s/w96ngfw6ndm0efv/NewColourUnselected.png?dl=0
https://www.dropbox.com/s/8two2gzko5ovbnz/NewColourSelected.png?dl=0
Attachment #8483175 -
Flags: review?(rnewman)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8483175 [details] [diff] [review]
Colour tweaks.
Review of attachment 8483175 [details] [diff] [review]:
-----------------------------------------------------------------
If it works, I'm happy.
Attachment #8483175 -
Flags: review?(rnewman) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8483175 [details] [diff] [review]
Colour tweaks.
Dependency for feature we'd like to turn on in 34. Sorry for the late approval request.
Attachment #8483175 -
Flags: approval-mozilla-beta?
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8483175 [details] [diff] [review]
Colour tweaks.
We're not going to ship bug 1092409 in 34. As such, we don't need to uplift to this patch to Beta.
Attachment #8483175 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
|
|
||
Updated•10 years ago
|
status-firefox34:
--- → wontfix
status-firefox35:
--- → fixed
|
||
Comment 9•10 years ago
|
||
Verified as fixed in builds:
- 36.0a1 2014-11-27;
- 35.0a2 2014-11-27;
Device: Samsung Galaxy R (Android 2.3.4).
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•