Closed
Bug 1061437
Opened 10 years ago
Closed 10 years ago
[Settings] Revert bug 1032071 and bug 1054122
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: arthurcc, Assigned: arthurcc)
References
Details
(Keywords: regression, smoketest)
Attachments
(1 file)
In bug 1032071 we embedded the BT app in settings app by using an iframe with mozapp and mozbrowser attributes. However, currently gecko does not support OOP apps embed apps yet (see bug 1059662) and which leads to crash of settings app (bug 1053107), so we decide to back out related patches.
EJ and Ian, would you mind take a look at the patch? Thanks.
Attachment #8482512 -
Flags: review?(iliu)
Attachment #8482512 -
Flags: review?(ejchen)
|
||
Updated•10 years ago
|
Attachment #8482512 -
Flags: review?(ejchen) → review+
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8482512 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/23563
The revert patch is okay for me on build version 20140829040202. Looks like latest build is not working fine with mozSettings. We see some problem in all of settings app(not only bluetooth app). It might be relative with Bug 900551.
Attachment #8482512 -
Flags: review?(iliu) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks for reviewing!
master: 5558ad0b068b5ddf45d7a532e133ab88a47f0beb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Keywords: regression,
smoketest
|
|
||
Updated•10 years ago
|
blocking-b2g: --- → 2.1+
|
||
Comment 4•10 years ago
|
||
Note that due to recent policy changes, all B2G uplifts needs approval now regardless of blocking status. Please request Gaia v2.1 approval on this patch when you get a chance. Sorry for the inconvenience.
|
|
||
Comment 5•10 years ago
|
||
Uplifted with IRC a=bajaj.
v2.1: https://github.com/mozilla-b2g/gaia/commit/fbb297c39aab5f17b179533d2a9a6c5166b2c197
You need to log in
before you can comment on or make changes to this bug.
Description
•