Closed Bug 1061685 Opened 10 years ago Closed 10 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.overlays.ui.ShareDialog.slideOut(ShareDialog.java)

Categories

(Firefox for Android Graveyard :: Overlays, defect)

35 Branch
ARM
Android
defect
Not set
critical

Tracking

(firefox34 disabled, firefox35 verified, fennec34+)

VERIFIED FIXED
Firefox 35
Tracking Status
firefox34 --- disabled
firefox35 --- verified
fennec 34+ ---

People

(Reporter: aaronmt, Assigned: ckitching)

References

Details

(Keywords: crash, reproducible)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is report bp-eb10738d-aa48-462c-8a7b-540802140902. ============================================================= java.lang.NullPointerException at org.mozilla.gecko.overlays.ui.ShareDialog.slideOut(ShareDialog.java:248) at org.mozilla.gecko.overlays.ui.ShareDialog.onTouchEvent(ShareDialog.java:281) at android.app.Activity.dispatchTouchEvent(Activity.java:2569) at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2243) at com.android.internal.policy.impl.MultiPhoneWindow$MultiPhoneDecorView.dispatchTouchEvent(MultiPhoneWindow.java:518) at android.view.View.dispatchPointerEvent(View.java:8343) at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:4743) at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:4609) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4167) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4221) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4190) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:4301) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4198) at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:4358) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4167) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4221) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4190) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4198) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4167) at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:6517) at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:6434) at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:6405) at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:6370) at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:6597) at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:185) at android.os.MessageQueue.nativePollOnce(Native Method) at android.os.MessageQueue.next(MessageQueue.java:138) at android.os.Looper.loop(Looper.java:123) at android.app.ActivityThread.main(ActivityThread.java:5579) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084) at dalvik.system.NativeStart.main(Native Method) I got this trying to 'Add to Nightly' from the Memo application (notepad) on my Galaxy S5. I got a toast "No link found in this share". The browser than crashes right after that.
Blocks: 1044947
The dialog tried sliding out but it doesn't exist amirite?
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
tracking-fennec: ? → 34+
on the other hand, perhaps Nightly shouldn't have been registered in this case if nothing is sharable?
(In reply to Aaron Train [:aaronmt] from comment #2) > on the other hand, perhaps Nightly shouldn't have been registered in this > case if nothing is sharable? We don't get that amount of fine-grained control, alas. Shared URLs are text/plain. Sometimes that means there's no link in what was shared.
Attachment #8483148 - Flags: review?(rnewman)
Comment on attachment 8483148 [details] [diff] [review] Finish activity after dispatching toast. Review of attachment 8483148 [details] [diff] [review]: ----------------------------------------------------------------- If this fixes the bug, then fine!
Attachment #8483148 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
There have been 0 crashes reported in the last week. I'm a bit puzzled if this landed in 35 and never uplifted to 34, I'd expect to still see crashes in 34. I'm flagging for QE verification given this is marked as reproducible.
Flags: qe-verify+
Is the share dialog enabled in Beta?
(In reply to Richard Newman [:rnewman] from comment #9) > Is the share dialog enabled in Beta? Sorry, I guess I'm not familiar enough with the feature. Can I get steps to reproduce? Maybe then I can answer your question.
The share overlay isn't built in beta or release: # Enable the share handler in pre-release builds. if test ! "$RELEASE_BUILD"; then MOZ_ANDROID_SHARE_OVERLAY=1 fi so there won't be any crashes in Beta 34.
Blocks: 1092409
Verified as fixed in Firefox for Android 35 Beta 1 using Samsung S5 (Android 4.4.2). "No link found in this share" toast is displayed, but Firefox does not crash.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: