Closed Bug 1061716 Opened 10 years ago Closed 10 years ago

Stop hardcoding carrier for some regions

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-10-07

People

(Reporter: julian.mozbugs, Assigned: mat)

References

Details

(Whiteboard: [repoman])

Steps to reproduce: 1. Load MP-stage app on your device with AT&T SIM card 2. Search for :debug 3. Look for carrier_sim Expected results: For carrier_sim, "at&t" value is displayed. Actual results: For carrier_sim is displayed "deutsche_telekom". Notes/Issues: Verified on FF OS 1.3 (Inari) with AT&T SIM card
This is not a new issue, it has always been the case, but we should stop doing that. The regions where we hardcode a carrier are: United States, Brazil, Colombia, Austria, Serbia, China, Japan. For these regions, we should only set the carrier if the SIM has the correct MNC.
Component: Code Quality → Consumer Pages
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: "deutsche_telekom" is displayed for carrier_sim in the :debug page → Stop hardcoding carrier for some regions
Target Milestone: 2014-09-09 → ---
Version: 1.4 → 2.0
Priority: -- → P2
Blocks: 1048896
Assignee: nobody → delza
Whiteboard: [repoman]
Assignee: delza → jeroentulp
Assignee: jeroentulp → nobody
Assignee: nobody → mpillard
Status: NEW → ASSIGNED
Fixed in https://github.com/mozilla/fireplace/commit/3ff148f28ec87fc50b17419684dce9e59aa7b8ab Note that you wouldn't see "at&t" since it's not a carrier we support atm, but you shouldn't see "deutsche_telekom" anymore if you don't have a DT/T-Mobile SIM Card.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-10-07
Now there are 2 lines "--" displayed on carrier_sim and region_sim while using the Movistar SIM. Is this expected? Also I can still see "deutsche_telekom" for carrier_sim while using the AT&T SIM.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Which country is your movistar SIM from ? Also, which package were you testing with ?
Flags: needinfo?(iulian.timis)
The Movistar SIM is from Spain. I have tested on both latest MP-stage and MP-dev apps on FF OS 1.4, FF35 on Android 4.2.1
Flags: needinfo?(iulian.timis)
Please post ashes then, I'm not sure what's going on.
Flags: needinfo?(iulian.timis)
MP-dev AT&T SIM Log ID: e758e MP-dev Movistar SIM Log ID: 77613
Flags: needinfo?(iulian.timis)
Your package_version is 20140925220444, indicating it was generated on 25th September, which is too old to have my code in it. Please update it. (The API updates in the background when you visit an app that you have already visited, so load https://marketplace-dev.allizom.org/app/marketplace/ and then reload, confirm that package_version is higher than 20140930?????? and update then. You can verify package_version in :debug once you have installed the package)
Also, you should test both SIMs on Firefox OS only. SIM carrier/region detection is not available on Android.
I have re-download the MP-dev app and now I'm seeing "--" for carrier_sim when using AT&T SIM and "telefonica" when using Movistar SIM.
Re-closing then, thanks.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Verified as fixed on MP-dev FF OS 1.4 (Inari). Closing bug. Thank you!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.