Closed
Bug 1061716
Opened 10 years ago
Closed 10 years ago
Stop hardcoding carrier for some regions
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-10-07
People
(Reporter: julian.mozbugs, Assigned: mat)
References
Details
(Whiteboard: [repoman])
Steps to reproduce:
1. Load MP-stage app on your device with AT&T SIM card
2. Search for :debug
3. Look for carrier_sim
Expected results:
For carrier_sim, "at&t" value is displayed.
Actual results:
For carrier_sim is displayed "deutsche_telekom".
Notes/Issues:
Verified on FF OS 1.3 (Inari) with AT&T SIM card
Assignee | ||
Comment 1•10 years ago
|
||
This is not a new issue, it has always been the case, but we should stop doing that. The regions where we hardcode a carrier are: United States, Brazil, Colombia, Austria, Serbia, China, Japan.
For these regions, we should only set the carrier if the SIM has the correct MNC.
Component: Code Quality → Consumer Pages
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: "deutsche_telekom" is displayed for carrier_sim in the :debug page → Stop hardcoding carrier for some regions
Target Milestone: 2014-09-09 → ---
Version: 1.4 → 2.0
Updated•10 years ago
|
Priority: -- → P2
Updated•10 years ago
|
Assignee: nobody → delza
Updated•10 years ago
|
Whiteboard: [repoman]
Updated•10 years ago
|
Assignee: delza → jeroentulp
Updated•10 years ago
|
Assignee: jeroentulp → nobody
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mpillard
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/3ff148f28ec87fc50b17419684dce9e59aa7b8ab
Note that you wouldn't see "at&t" since it's not a carrier we support atm, but you shouldn't see "deutsche_telekom" anymore if you don't have a DT/T-Mobile SIM Card.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2014-10-07
Reporter | ||
Comment 4•10 years ago
|
||
Now there are 2 lines "--" displayed on carrier_sim and region_sim while using the Movistar SIM. Is this expected?
Also I can still see "deutsche_telekom" for carrier_sim while using the AT&T SIM.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•10 years ago
|
||
Which country is your movistar SIM from ? Also, which package were you testing with ?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(iulian.timis)
Reporter | ||
Comment 6•10 years ago
|
||
The Movistar SIM is from Spain. I have tested on both latest MP-stage and MP-dev apps on FF OS 1.4, FF35 on Android 4.2.1
Flags: needinfo?(iulian.timis)
Assignee | ||
Comment 7•10 years ago
|
||
Please post ashes then, I'm not sure what's going on.
Flags: needinfo?(iulian.timis)
Reporter | ||
Comment 8•10 years ago
|
||
MP-dev AT&T SIM Log ID: e758e
MP-dev Movistar SIM Log ID: 77613
Flags: needinfo?(iulian.timis)
Assignee | ||
Comment 9•10 years ago
|
||
Your package_version is 20140925220444, indicating it was generated on 25th September, which is too old to have my code in it. Please update it.
(The API updates in the background when you visit an app that you have already visited, so load https://marketplace-dev.allizom.org/app/marketplace/ and then reload, confirm that package_version is higher than 20140930?????? and update then. You can verify package_version in :debug once you have installed the package)
Assignee | ||
Comment 10•10 years ago
|
||
Also, you should test both SIMs on Firefox OS only. SIM carrier/region detection is not available on Android.
Reporter | ||
Comment 11•10 years ago
|
||
I have re-download the MP-dev app and now I'm seeing "--" for carrier_sim when using AT&T SIM and "telefonica" when using Movistar SIM.
Assignee | ||
Comment 12•10 years ago
|
||
Re-closing then, thanks.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 13•10 years ago
|
||
Verified as fixed on MP-dev FF OS 1.4 (Inari).
Closing bug.
Thank you!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•