Closed Bug 1061772 Opened 10 years ago Closed 10 years ago

Profiler cost percentage should be calculated based on number of samples and not samples delta time

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: BenWa, Assigned: vporof)

Details

Attachments

(2 files)

Attached image Screenshot (deleted) —
See bug 1061759, I'm going to be calling the 3rd column 'Samples' from here on out. If you look at the screenshot, compare the (root) node with DSC_allocId. Notice that (root) has 100% cost but DSC_allocId has 17%. This doesn't seem to add up at all with the call/samples count. Profile from bug 1045715.
The 17% is time, not samples.
What is the 3rd column and why is the 3rd column not equal to the second column multiplied by a constant?
I discussed with victor in person. We added a sample time back in the day to the profiler backend to know when the profiler failed to capture a sample on time. In the screenshot we're using this to compute duration/time but we agreed that this wasn't accurate to report as Cost/Time since really we don't know what occurred during these missed samples and charging that to the site where we finally take the sample is misleading.
Summary: Profiler columns don't add up → Profiler cost percentage should be calculated based on samples and not samples delta time
Assignee: nobody → vporof
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Priority: -- → P2
Summary: Profiler cost percentage should be calculated based on samples and not samples delta time → Profiler cost percentage should be calculated based on number of samples and not samples delta time
Attached patch v1 (deleted) — Splinter Review
Attachment #8491677 - Flags: review?(pbrosset)
Comment on attachment 8491677 [details] [diff] [review] v1 Review of attachment 8491677 [details] [diff] [review]: ----------------------------------------------------------------- Alright, this change makes sense to me. In these kinds of UIs though, it's hard to know what each column mean and how it's calculated, so it's hard for a user to know what to look for when investigating problems. So I think column header tooltips would help here.
Attachment #8491677 - Flags: review?(pbrosset) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: