Stephany Wilkes Reporter
	Description • 10 years ago

FTU search suggestion needs a new string. Francis to provide in order to make 9/2 string freeze deadline.

	Francis Djabri [:djabber]
	Comment 1 • 10 years ago

When typing in the search app for the first time, the user is shown the following message in a pop-up:

"Search suggestions are shown as you type. Go to the Homescreen section of Settings to change your search preferences". 

The search suggestions now have their own section in settings for 2.1. We also got feedback that the string was not informative enough to users re: privacy. Please change the string to:

"The characters you type are sent to multiple search providers and are used to send you search suggestions. Go to the Search section of Settings to change your search preferences".

	Candice Serran (:cserran)
	Comment 2 • 10 years ago

(In reply to Stephany Wilkes from comment #0)
> FTU search suggestion needs a new string. Francis to provide in order to
> make 9/2 string freeze deadline.

Hey guys...is there a reason why this is coming in so late for 2.1?

	Kevin Grandon :kgrandon Assignee
	Comment 3 • 10 years ago

(In reply to Candice Serran (:cserran) from comment #2)
> Hey guys...is there a reason why this is coming in so late for 2.1?

It seems like we missed tracking some work to update this in 2.1. We had implemented this in 2.0 for the previous settings panel implementation, but it seems that we forgot to track this with a bug when doing the settings panel movement.

	Axel Hecht [:Pike]
	Comment 5 • 10 years ago

I'm not sure how this relates to branch mechanics for 2.1 today, so flagging this as late-l10n.

I'd like a localization note referencing that "Search" and "Settings" are app names.

	Axel Hecht [:Pike]
	Comment 6 • 10 years ago

doh, wrong pike again.

	Francis Djabri [:djabber]
	Comment 7 • 10 years ago

Just reviewed this on device with Kevin and the string looked over-long, so we decided to shorten this to:

"The characters you type are used to show you search suggestions. Go to the Search section of Settings to change your search preferences".

	Kevin Grandon :kgrandon Assignee
	Comment 8 • 10 years ago

Comment on attachment 8483040 [details]
Github pull request

Axel - Would you be willing/able to review this since it might be late l10n and to see if you're happy with the localization note? Thanks!

	Axel Hecht [:Pike]
	Comment 9 • 10 years ago

Comment on attachment 8483040 [details]
Github pull request

Technically, and copy-wise, this seems to be OK.

Given that this is post the 2.1 branch changeset, this will need approval in its own right, my review doesn't make a statement on its branch-worthiness.

PPS: I'm not really a gaia reviewer, but this patch is close enough to l10n-only that I don't think it's worth sending you off for a another review.

	Kevin Grandon :kgrandon Assignee
	Comment 10 • 10 years ago

Comment on attachment 8483040 [details]
Github pull request

We would like to uplift this to 2.1.

[Bug caused by] (feature/regressing bug #): Missed feature scope.
[User impact] if declined: An invalid notice will be displayed to the user (This feature was changed in the Settings app, but the notice was never updated)
[Testing completed]: Manual verification and UI-review with Francis
[Risk to taking this patch] (and alternatives if risky): It's l10n only so low risk.
[String changes made]: Yes, added a new string in the Search app.

	Kevin Grandon :kgrandon Assignee
	Comment 11 • 10 years ago

In master: https://github.com/mozilla-b2g/gaia/commit/27c098b771f4b575dbf82df2727969ae7748070a

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/adc16be74c6450438e1226d028a51deb820b1889

	SandKing
	Comment 13 • 10 years ago

This issue has been verified successfully on Flame2.1&2.2
Verify video:"verify_1061931.mp4".

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.034824
FW-Date         Tue Dec  2 03:48:34 EST 2014
Bootloader      L1TC00011880

Flame2.2 bulid:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141202.072347
FW-Date         Tue Dec  2 07:23:58 EST 2014
Bootloader      L1TC00011880