Closed
Bug 1061995
Opened 10 years ago
Closed 10 years ago
Keep forcing windowless plugin mode in e10s
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox32 unaffected, firefox33 unaffected, firefox34 fixed, firefox35 fixed)
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | unaffected |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
People
(Reporter: johns, Assigned: johns)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jst
:
review+
lmandel
:
approval-mozilla-aurora+
johns
:
checkin+
|
Details | Diff | Splinter Review |
Bug 853995 cleaned up the plugin parameters code and inadvertently dropped the bug 923745 workaround to force flash to windowless mode until windowed mode works again
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8483146 -
Flags: review?(jst)
Updated•10 years ago
|
Attachment #8483146 -
Flags: review?(jst) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8283057311
Attachment #8483146 -
Flags: checkin+
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode
I guess we should nom this on the off chance someone wants to e.g. bisect something on aurora, it doesn't have any effect on non-e10s mode regardless
Approval Request Comment
[Feature/regressing bug #]: Bug 853995 inadvertently dropped this workaround
[User impact if declined]: e10s plugins are (even more) broken. Not sure that anyone should be using e10s mode on aurora, but the check only affects e10s mode either way.
[Describe test coverage new/current, TBPL]: None, plugins aren't passing in e10s tests yet
[Risks and why]: None, e10s-only, and just restoring chunk of code inadvertently removed in 34
[String/UUID change made/needed]: None
Attachment #8483146 -
Flags: approval-mozilla-aurora?
Comment 5•10 years ago
|
||
Comment on attachment 8483146 [details] [diff] [review]
Restore bug 923745 workaround for windowless flash in e10s mode
I think we're still early enough where we can to put back this chunk of code in Aurora. Approved.
Attachment #8483146 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
status-firefox32:
--- → unaffected
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → fixed
Comment 6•10 years ago
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•