Closed Bug 1062007 Opened 10 years ago Closed 10 years ago

"Developer HUD" header is not localized anymore

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: tchevalier, Assigned: tchevalier)

References

Details

Attachments

(2 files)

Flame 2.2
(deleted), image/png
Details
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23652
(deleted), text/x-github-pull-request
jj.evelyn
: review+
fabrice
: approval-gaia-v2.1+
Details 
Regression from Bug 1015297, an l10n id has been changed.

Attaching a tiny patch to revert to the right entity, hud-settings-header
We'll need to uplift to 2.1
Attached image Flame 2.2 (deleted) — 

  

  


Assignee: nobody → tchevalier
Status: NEW → ASSIGNED

    
    

    
  


  
Hi Evelyn, could you rubber-stamp this one for me please?

  

  



        Attachment #8483152 -
        Flags: review?(ehung)

    
  

        Attachment #8483152 -
        Flags: review?(ehung) → review+

    
    

    
  
Thanks, setting checkin-needed

[Blocking Requested - why for this release]:
Unlocalized header in Settings, as on the screenshot

  

  


blocking-b2g: --- → 2.1?
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/6cbf3fcf465f5525cfbc34e28c4a7ae8312ad963

  

  


Status: ASSIGNED → RESOLVED
Closed: 10 years ago

          status-b2g-v2.2:
          affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)

    
    

    
  
Théo, please set approval flag on the patch?

  

  


blocking-b2g: 2.1? → 2.1+
Flags: needinfo?(tchevalier)

    
    

    
  
Comment on attachment 8483152 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23652

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1015297
[User impact] if declined: One header in English for all users in Settings
[Testing completed]: Tested on 2.2 with French
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

  

  



        Attachment #8483152 -
        Flags: approval-gaia-v2.1?
Flags: needinfo?(tchevalier)

        Attachment #8483152 -
        Flags: approval-gaia-v2.1? → approval-gaia-v2.1+

    
    

    
  
Verified fixed on Flame 2.2 (319mb/full flash) and Flame 2.1 (319mb/full flash) 

Actual result: The developer header is localized. Tested Italian and German in 2.1, French in 2.2

Device: Flame 2.2
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

  

  


Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]

          status-b2g-v2.1:
          fixed → verified

          status-b2g-v2.2:
          fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: