Closed
Bug 1062105
Opened 10 years ago
Closed 10 years ago
[Keyboard] Alternate keys list overflows needs UI improvement
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: Carol, Assigned: rudyl)
Details
(Whiteboard: [p=1])
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
application/pdf
|
Details | |
|
(deleted),
text/x-github-pull-request
|
timdream
:
review+
Carol
:
ui-review+
|
Details |
2014-09-03-14-07-22.png
Alternate keys list overflows needs UI improvement.
|
Reporter | |
Comment 1•10 years ago
|
||
There's some divider missing issue.
Need to check the position of the overflow menu in both 1 line and 2 lines situation as well.
I will attach the visual spec later.
|
|
Reporter | |
Comment 2•10 years ago
|
||
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rlu
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S4 (12sep)
|
|
Assignee | |
Comment 3•10 years ago
|
||
This is mostly UI change, so I'd like to ask for UI review first.
Carol,
Could you please help review this change?
Thank you.
Attachment #8486344 -
Flags: ui-review?(chuang)
|
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8486344 [details]
Patch V1
Hi Rudy,
The UI looks pretty good! Thank you!!
Attachment #8486344 -
Flags: ui-review?(chuang) → ui-review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8486344 [details]
Patch V1
This patch passed the UI review and the CI test.
Tim, could you please review this?
Attachment #8486344 -
Flags: review?(timdream)
|
||
Updated•10 years ago
|
Attachment #8486344 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
All is good, landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/28266041a9e78abd9bc4ec6a1cc85e9d9097c573
--
Thanks for the review.
You need to log in
before you can comment on or make changes to this bug.
Description
•