Closed
Bug 1062197
Opened 10 years ago
Closed 10 years ago
Fix hardcoded strings in Messaging settings
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 fixed)
People
(Reporter: tchevalier, Assigned: tchevalier)
References
Details
Attachments
(5 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-github-pull-request
|
jj.evelyn
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details |
(deleted),
text/plain
|
jj.evelyn
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
video/mp4
|
Details |
Two strings are displayed in English in Messaging settings:
"SIM settings" (Header)
"Info not available"
Attaching a PR to fix it. We already have the strings, just need to fix the template.
Assignee | ||
Comment 1•10 years ago
|
||
Evelyn, if you could give a quick review to this one as well… Thanks! :)
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Comment 2•10 years ago
|
||
Comment on attachment 8483367 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23668
oh man, we should really fix bug 928740 to avoid this kind of trivial issue happens again... anyway, thank you for taking care of this. :)
Attachment #8483367 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Unfortunately, not going to happen anytime soon, our best friend in the meantime is still Accented English :)
[Blocking Requested - why for this release]:
Two unlocalized strings in Messaging settings, bad user experience.
blocking-b2g: --- → 2.1?
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
Comment 5•10 years ago
|
||
Théo, please set approval flag on the patch?
blocking-b2g: 2.1? → 2.1+
Flags: needinfo?(tchevalier)
Assignee | ||
Comment 6•10 years ago
|
||
I got fooled by the string in HTML, the real string is "SIM {{index}} Settings", so right now it doesn't work, we need to give it the SIM number.
I'll attach a follow up PR (or I should open a follow up bug? But that sounds a lot of paperwork for such a trivial issue…)
Flags: needinfo?(tchevalier)
Comment 7•10 years ago
|
||
Note that due to recent policy changes, all patches need approval for uplift regardless of blocking status. Please request Gaia v2.1 approval on this patch when you get a chance. Sorry for the inconvenience :(
Flags: needinfo?(tchevalier)
Assignee | ||
Comment 8•10 years ago
|
||
Follow up, the variable was not properly replaced because of a bad selector.
Tested on Flame 2.2, sorry I didn't catch that earlier :/
I'd say we can land this one on master then both on 2.1
Attachment #8484529 -
Flags: review?(ehung)
Flags: needinfo?(tchevalier)
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8483367 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23668
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1001285
[User impact] if declined: English strings in Messaging settings for all users
[Testing completed]: Tested on Flame device on 2.2
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none
Attachment #8483367 -
Flags: approval-gaia-v2.1?
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8484529 [details]
(follow up) Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23741/files
[Approval Request Comment]
Same as for previous PR, follow up
Attachment #8484529 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Attachment #8484529 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Thanks Evelyn, setting checkin-needed for the follow up
Keywords: checkin-needed
Comment 13•10 years ago
|
||
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #8483367 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Updated•10 years ago
|
Attachment #8484529 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 14•10 years ago
|
||
Comment 16•10 years ago
|
||
Unable to verify this issue as we do not have SIM Card that has unknown SMSC state. This makes it impossible to verify the string "Info Not Available" is properly translated.
QA Whiteboard: [QAnalyst-Triage?][qanalyst-verify]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][qanalyst-verify] → [QAnalyst-Triage+][qanalyst-verify]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+][qanalyst-verify] → [QAnalyst-Triage+][QAnalyst-verify-]
Comment 17•10 years ago
|
||
Hi Josh,
This issue has been verified successfully on Flame2.1
See video: "verify_1062197.MP4".
Flame2.1 build:
Gaia-Rev afdfa629be209dd53a1b7b6d6c95eab7077ffcd9
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6
Build-ID 20141123001201
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141123.035029
FW-Date Sun Nov 23 03:50:40 EST 2014
Bootloader L1TC00011880
Comment 18•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•