Closed Bug 1062235 Opened 10 years ago Closed 10 years ago

Port bug 1062221 (kill add_tier_dir) to comm-central

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

Port bug 1062221 to c-c
(deleted), patch
jcranmer
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Port bug 1062221 to c-c (obsolete) (deleted) — — Splinter Review
This is largely untested. Please test.
Attachment #8483407 - Flags: review?(Pidgeot18)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8483407 [details] [diff] [review] Port bug 1062221 to c-c This won't work without changes to python/mozbuild.
Attachment #8483407 - Flags: review?(Pidgeot18)
Comment on attachment 8483407 [details] [diff] [review] Port bug 1062221 to c-c Review of attachment 8483407 [details] [diff] [review]: ----------------------------------------------------------------- See my comment on bug 1062221. Depending on how the emitter.py changes are fixed, this patch may not be the correct patch to apply.
Attached patch Port bug 1062221 to c-c (obsolete) (deleted) — — Splinter Review
AFAICT, combined with the three patches in bug 1062221, this should make c-c build.
Attachment #8484064 - Flags: review?(Pidgeot18)
Attachment #8483407 - Attachment is obsolete: true
Comment on attachment 8484064 [details] [diff] [review] Port bug 1062221 to c-c Review of attachment 8484064 [details] [diff] [review]: ----------------------------------------------------------------- I must say, I'm not thrilled about the need for '/' in path names to execute comm-central and omitting it for mozilla-central. But this is a casualty of the patches in bug 1062221, so it's not worth complaining about in this bug.
Attachment #8484064 - Flags: review?(Pidgeot18) → review+
(In reply to Joshua Cranmer [:jcranmer] from comment #5) > Comment on attachment 8484064 [details] [diff] [review] > Port bug 1062221 to c-c > > Review of attachment 8484064 [details] [diff] [review]: > ----------------------------------------------------------------- > > I must say, I'm not thrilled about the need for '/' in path names to execute > comm-central and omitting it for mozilla-central. But this is a casualty of > the patches in bug 1062221, so it's not worth complaining about in this bug. Actually, I have another patch series that turns them all to use '/'. Will file a separate bug soon.
See bug 1063414.
Attached patch Port bug 1062221 to c-c (deleted) — — Splinter Review
Same as previous patch, but with '/' everywhere (which is going to be the case on m-c too, with bug 1063414)
Attachment #8498531 - Flags: review?(Pidgeot18)
Attachment #8484064 - Attachment is obsolete: true
Attachment #8498531 - Flags: review?(Pidgeot18) → review+
Summary: Port bug 1062221 to comm-central → Port bug 1062221 (kill add_tier_dir) to comm-central
Fixes the build of TB for me.
Keywords: checkin-needed
Version: unspecified → Trunk
https://hg.mozilla.org/comm-central/rev/358616dd22ab
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: