Closed
Bug 1062580
Opened 10 years ago
Closed 10 years ago
[Browser] Overflow menu 'Show Windows' needs to call Task Manager with correct filter.
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Tracking
(b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
People
(Reporter: aus, Assigned: aus)
References
Details
(Whiteboard: [systemsfe][p=1])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
benfrancis
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details |
The custom event should have the following event detail:
{ detail: { filter: 'browser-only' }}
Assignee | ||
Updated•10 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
I changed it in both app_chrome and browser_context_menu, not sure both are required as only the latter is called currently (but I distinctly remember app chrome being called instead with the new style overflow menus).
Attachment #8483823 -
Flags: review?(bfrancis)
Comment 2•10 years ago
|
||
Comment on attachment 8483823 [details]
Pull Request - Send 'taskmanagershow' with correct filter as detail
This is correct, the AppChrome method is used for the button displayed on the Rocketbar on the browser start page.
Thanks :)
Attachment #8483823 -
Flags: review?(bfrancis) → review+
Comment 3•10 years ago
|
||
Please investigate the failing unit test before landing, and request uplift to 2.1.
Assignee | ||
Comment 4•10 years ago
|
||
Failing test looks like a known intermittent but, I did rebase against the latest master. Hopefully everything passes this time.
https://tbpl.mozilla.org/?rev=40be0348d7b087c0eeb62b01d8a1bd3a33fe4855&tree=Gaia-Try
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8483823 [details]
Pull Request - Send 'taskmanagershow' with correct filter as detail
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Impossible for user to easily access browser windows via 'Show Windows' in Browser and Rocketbar. It would instead show *all* windows.
[Testing completed]: On Device (Flame Full, Flame 319).
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.
Attachment #8483823 -
Flags: approval-gaia-v2.1?
Assignee | ||
Comment 6•10 years ago
|
||
Behold the greenness of my gaia-try run!
Commit (master): https://github.com/mozilla-b2g/gaia/commit/2ad4a6b1aa929d89f3f2fea1c6efb511b2227c0c
Leaving open, hoping for 2.1 approval. :)
Keywords: leave-open
Assignee | ||
Comment 7•10 years ago
|
||
Flagging ni? for approval-gaia-2.1. I was hoping to be able to wrap this up this week. :)
Flags: needinfo?(bbajaj)
Updated•10 years ago
|
Attachment #8483823 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Flags: needinfo?(bbajaj)
Assignee | ||
Comment 8•10 years ago
|
||
Commit (v2.1): https://github.com/mozilla-b2g/gaia/commit/eabddf6abe10a95d24086cc35f9633d80043ac97
Fixed!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [systemsfe] → [systemsfe][p=1]
You need to log in
before you can comment on or make changes to this bug.
Description
•