Flame, while running: Gaia fbb297c39aab5f17b179533d2a9a6c5166b2c197 SourceStamp fb5e796da813 BuildID 20140903000204 Version 34.0a2 base image: v123 512 MB STR: 1. Launch camera 2. Tap the shutter button Expected: Picture would be taken Actual: Picture is not taken Logcat attached

I've observed three things that might match Marcia's description 1) I tried the camera with today's nightly build and 319mb memory. I twice saw something like the bug: I tap the shutter button, it turns blue, a focus ring appears, and then nothing happens. The button remains hightlighted and no picture is taken. Tapping again took the picture and restored the camera to normal operation. 2) And then with more testing I once got the camera into a state where the shutter button was disabled and remained disabled. It stays white, and when I tap on it, the focus ring moves under the button (see bug 1063106). In this case the button stays white and I can't recover by tapping a second time. Some kind of race condition has left the shutter permanently disabled. I don't know what I did to get into this state. The switch camera, flash, and menu buttons work, but the shutter button and the photo/video button do not work. Switching to the selfie camera does not make the shutter button work again. (If I had to guess, I'd say that what's happening is probably related to focus... The user taps on the shutter button, and as part of getting ready to take the picture we disable the button. Then something goes wrong with focus and we abort taking the picture, but the button doesn't get re-enabled and we're stuck) 3) I also saw what seems like a different bug where after zooming in or out with a pinch gesture, the next tap on the shutter button (or on flash, menu, etc) would not be handled. I'll file a separate bug for that, though.

Needinfo Marcia: do you recall whether you saw #1 or #2? Needinfo Justin and Diego: because it seems like this should be on your radar. qawanted: it would be nice to know if anyone can find reliable STR for #1 or #2, and whether these occur in earlier releases.

Per Justin, #2 (in comment #1) is a dupe of bug 1058016 (which depends on the device storage bug 1058425). When that bug occurs in camera, if I try to open up gallery, I'll get a message saying I don't have an sdcard. Apparently it is JB only. And I've filed bug 1063138 about issue #3 from comment #1. So I think this bug is just about issue #1. I still don't have STR, but I have seen it happen a couple more times. I think it has something to do with trying to use the shutter button while the camera is auto-focusing.... Aim the camera at something close, then aim it at something far away and when the white focus ring appears, hit the shutter button before the ring turns green. Either on that photo or the next one, maybe the shutter button will turn blue and stay blue but not take a picture. Or something like that. But I can't do it reliably and am not certain that is what was happening when I tried it. Maybe it is something more devious like I press the shutter button at just about the same time that the camera decided to autofocus so it ends up trying to take a picture right after it started focusing on its own or something. It seems like this is less than one time out of 50, but I've seen this 3 or 4 times now.

djf: What I saw was definitely #2.

Marcia - if what you saw was #2, and #2 is considered a dupe (see comment 3); should this bug be closed as a dupe then?

(In reply to Joshua Mitchell [:Joshua_M] from comment #5) > Marcia - if what you saw was #2, and #2 is considered a dupe (see comment > 3); should this bug be closed as a dupe then? Joshua: From what I can from Comment 3, djf was seeing an the #1 issue which is what I think is what he wants qawanted for. So please try to reproduce the #1 issue in Comment 1.

Adjusting my testing to follow Marcia's comment 6. I'm Looking at scenario #1 in Comment 1 and providing my findings. STR: 1. Launch Camera 2. Take a photo. 3. Tap Home to put the camera into the background. 4. Relaunch Camera. 5. Tap and hold finger on the shutter button until it turns blue. 6. Slide your finger away from the shutter button. 7. Notice the shutter button stays blue and does not take a photo. 8. Tap again and a photo is taken and the button goes back to it's default state. ***NOTE: On the OpenC device, these str's did not work. Instead I just kept tapping the shutter button rapidly and it got stuck. This bug repro's on: Flame 2.2, Flame 2.1, Flame 2.0, OpenC 2.2 Actual Results: Able to get the camera shutter to stay blue with no picture taken. Subsequent taps will work correctly and take photos. Repro Rate: 8/10 Environmental Variables: Device: Flame Master BuildID: 20140908163110 Gaia: 4acd3e69b263b54f4111e3586ff4ade84b49b4da Gecko: 6b8da5940f74 Version: 35.0a1 (Master) Firmware Version: v123 ----------------------------------------------- Device: Flame 2.1 BuildID: 20140909080656 Gaia: ece265efa8e87765713ac905e8ff55657fcbde01 Gecko: 3b49cf3e2043 Version: 34.0a2 (2.1) Firmware: V123 ------------------------------------------------ Device: Flame 2.0 BuildID: 20140908131505 Gaia: 59a670d40ad7f5966ec7fafcab0f05009bea97ab Gecko: de70f9a40834 Version: 32.0 (2.0) Firmware: V123 ------------------------------------------------ Device: Open_C 2.2 BuildID: 20140908062801 Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d Gecko: f7a27a866c47 Version: 35.0a1 (2.2) Firmware: P821A10v1.0.0B06_LOG_DL ------------------------------------------------ ------------------------------------------------ This bug does NOT repro on: Flame 1.4 Actual Result: Unable to get the shutter button to remain blue when not holding the button. Repro Rate: 0/10 attempts Environmental Variables: Device: Flame 1.4 BuildID: 20140905100238 Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54 Gecko: a3e8df746cd8 Version: 30.0 (1.4) Firmware Version: v123

[Blocking Requested - why for this release]: breaks functionality in a major feature (camera)

Triage concluded blocking+. Regression from previous release, and STR describe common basic camera usage.

Bug 1011389 seems to be the cause for this issue. Mozilla-inbound Regression Window Last working Environmental Variables: Device: Flame Master BuildID: 20140516103004 Gaia: 799b0f8bb71bc1b944f90c117ab5d6be4837ba1f Gecko: bf98b86fbea2 Version: 32.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 First Broken Environmental Variables: Device: Flame Master BuildID: 20140516133004 Gaia: 17cc405ab6163528efe321e831bf0e72d1166a28 Gecko: 505f38b0649b Version: 32.0a1 (Master) Firmware Version: v123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Last working gaia / First broken gecko - Issue DOES occur Gaia: 799b0f8bb71bc1b944f90c117ab5d6be4837ba1f Gecko: 505f38b0649b First broken gaia / Last working gecko - Issue does NOT occur Gaia: 17cc405ab6163528efe321e831bf0e72d1166a28 Gecko: bf98b86fbea2 Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bf98b86fbea2&tochange=505f38b0649b

Broken by Bug 1011389 ?

Bug 1011389 did change the behaviour on long-press which is what the STR in comment 7 include. I can do a quick investigation to see what events we are delivering from the platform side in this case and whether or not they make sense. Leaving needinfo on me for now.

So as far as I can tell the actual events delivered to content are fine. Touch-down, touch-up, touch-move, long-press, and click events are all delivered as I would expect based on what my finger is doing. I also notice that the MOZLONGTAP event dispatched from the long-press is consumed somewhere, which is why a long-press + touch-up doesn't trigger a click event. Now in terms of what the expected behaviour: it sounds like the expectation is that the shutter doesn't remain blue after you slide your finger off. This may very well require a change in the APZ code (ActiveElementManager specifically) but we asked UX for a spec (bug 1009684) on how the focus behaviour should work and we are still waiting on that. I don't want to make any changes without properly considering all the use cases and having a "blessed" spec from the UX side. In terms of the actual camera behaviour and whether or not a photo should be taken on long-pressing the shutter button, that would be up to the camera app.

If you long press the shutter button, the button turns blue and when you release, it should take a picture. If that is not the actual behavior in 2.0, this bug is definitely a release blocker. I don't have an open C, but I can't reproduce the case where it gets stuck when I rapidly tap on shutter button on my flame. But for the case where you long press and slide off, the expected behavior is to *not take a picture*. And that is exactly what's happening. However, the blue highlighting still remains and that is because of css :active state issue as katz indicated in an earlier comment (depends on bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1009684). User can re-tap the shutter button to reset (where the blue highlighting disappears). So if the only issue is that blue highlighting on shutter button persists (until you re-tap) upon long press and slide off, it probably should not block 2.0 release (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block) Sri, what's your input? Thanks Hema

Yes, this looks another issue with the active state not behaving properly. Just added this bug to bug 1014322 that tracks all these problems.

As long as the blue highlighting issue (bug 1009684) is fixed, I agree we don't need to block on this. I don't think the long press should take pictures. Tapping the shutter button is the right way to go..

Moving it out of 2.0 blocker list. The issue is dependent on bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1009684 which is slotted in for 2.2 release consideration.

(In reply to Hema Koka [:hema] from comment #17) > Moving it out of 2.0 blocker list. The issue is dependent on bug: > https://bugzilla.mozilla.org/show_bug.cgi?id=1009684 which is slotted in for > 2.2 release consideration. to be clear, reason for removing this from release blocker at this stage in 2.0 release is because the blue highlighting on shutter button issue is happening only with tap and slide and user can revert back by tapping (see comment 14). If this is a critical impact that is overlooked, please renom

I don't seem to be able to reproduce the shutter-button-stays-blue issue with: - gonk: v184 - gecko: aurora:c4a4b04c617c - gaia: v2.1:778ebac47554e1c4b7e9a952d73e850f58123914

Firefox OS is not being worked on