Closed Bug 1062794 Opened 10 years ago Closed 10 years ago

Task tracer ignores zero SourceEventId

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file)

While debugging bug 1053946 I found that some events are missing from the log although there were labels referencing them. After some digging I found that those are events with zero SourceEventId. I'm not sure if zero SourceEventId is normal but I had to remove the filtering so those events were properly logged. We should either assign the SourceEventId with correct value or remove the filter from log utilities.
Blocks: 995058
Attached patch Allow UNKNOWN source event type (deleted) — Splinter Review
Record tasks even when the source event type is unknown to collect the complete information for analysis. They could always be filtered out in post-processing. Kyle, you reviewed the first task tracer patch series so I guess this is also yours ;)
Assignee: nobody → kchen
Status: NEW → ASSIGNED
Attachment #8495801 - Flags: review?(khuey)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: