User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 Build ID: 20140825202822 Steps to reproduce: This Image is not shown in new Firefox Version 32: http://www.versicherungsjournal.de/yellowdot_alt.gif In older Versions and in other Browsers it is shown. So i have opened it in Gimp and exported as: http://www.versicherungsjournal.de/yellowdot.gif And this gif is shown in all Browsers und also in Firefox Version 32 ?!

Is the original gif valid? We did make some changes where invalid images stopped being displayed.

(In reply to Milan Sreckovic [:milan] from comment #1) > Is the original gif valid? yellowdot_alt.gif is the original and i dont know if it is invalid. When I opened it in GIMP there is no hint that it could be invalid. Witch Program can show me if a picture is invalid?

Last good revision: 4511d9ac1000 First bad revision: 79624417d247 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4511d9ac1000&tochange=79624417d247

I'm somewhat confused. Is that suppose to be yellow or red? I see yellowdot_alt.gif as red everywhere (outside of firefox), but yellowdot.gif is yellow. It shows up on Firefox if you zoom out, which suggests the image is being decoded correctly but there's something wrong in the single color optimization path.

http://www.versicherungsjournal.de/yellowdot_alt.gif shows a red square in older Firefox,Seamonkey versions and IE11 but this image fails to display in Firefox trunk versions. I used this image for my regression test. I don't know if this is important or not but my Firefox24ESR and also older versions show a small blank gap between the red image and the black transparent background of the "Image only view mode" of newer Firefox versions. The "fixed" version of the image http://www.versicherungsjournal.de/yellowdot.gif shows indeed as yellow.

I would add a test, but I have no idea how to generate a gif that uses an offset. Gimp just removes the padding. Might just have to encode a gif myself if I can't find a free program that will do this.

Sorry i have chosen the wrong Domain it shuld be at not de, but there is the same Problem: http://www.versicherungsjournal.at/yellowdot_alt.gif (this "invalid" square should be a red square) http://www.versicherungsjournal.at/yellowdot.gif (this red square is shown correctly)

Comment on attachment 8484694 [details] [diff] [review] Fix drawing of padded single color optimized images Review of attachment 8484694 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks for fixing this! A test would indeed be ideal.

I figured out how to make a gif that'll hit this path. Make a single color image. In my case, I made a 16x16 green image. Then, use imagemagick: convert test.gif -crop 10x10+3+3 test2.gif Using this test image, it looks like this fix is *not* enough. The whole image is being filled instead of just the region with the color.

This seems more right to me, but I'm not sure if it's completely right. It seems like we should be using the padding data more or ignoring it. At any rate, it fixes my test case.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=80291d10c8b1

Comment on attachment 8487437 [details] [diff] [review] Fix drawing of padded single color optimized images, v2 Review of attachment 8487437 [details] [diff] [review]: ----------------------------------------------------------------- Very nice. Thanks Michael! ::: image/src/imgFrame.cpp @@ +342,4 @@ > > // Fill 'available' with whatever we've got > if (mSinglePixel) { > + target->FillRect(ToRect(aRegion.Intersect(available).Rect()), That actually makes tremendously more sense than the existing code, especially given the comment right above the |if|! ::: image/test/reftest/gif/reftest.list @@ +19,5 @@ > # test for bug 641198 > skip-if(B2G) random-if(Android) == test_bug641198.html animation2a-finalframe.gif # bug 773482 > > +# a gif with a single color and an offset > +== one-color-offset.gif one-color-offset-ref.gif You should indicate somewhere which bug this comes from.

Comment on attachment 8487437 [details] [diff] [review] Fix drawing of padded single color optimized images, v2 Approval Request Comment [Feature/regressing bug #]: Regressed by bug 994081 which landed in gecko 32. [User impact if declined]: Certain valid GIFs won't display. [Describe test coverage new/current, TBPL]: A test has been added to test this type of GIF. [Risks and why]: Should be low risk - these gifs are already broken and don't render on gecko 33-34. Can't get worse. [String/UUID change made/needed]: None

https://hg.mozilla.org/releases/mozilla-aurora/rev/da28c4c2bebf This needs rebasing around bug 1043560 for beta uplift. Also, please nominate this for b2g32 approval as well if you feel it's something that should be fixed for v2.0.

Here's a patch for beta.

Thanks :) https://hg.mozilla.org/releases/mozilla-beta/rev/232c3b4708b9 FWIW, this applies trivially to b2g32 if you want to uplift it there too :)

Comment on attachment 8493344 [details] [diff] [review] Fix drawing of padded single color optimized images, v2 (Gecko 33 / Beta) NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Regressed by bug 994081 which landed in gecko 32. User impact if declined: Certain valid GIFs won't display. Testing completed: A test has been added to test this type of GIF. Risk to taking this patch (and alternatives if risky): Should be low risk - these gifs are already broken and don't render. String or UUID changes made by this patch: None

[Blocking Requested - why for this release]: Certain valid GIFs won't display. See comment 19 for more details.

The triage group agrees that regressions can't be shipped so 2.0+.

Comment on attachment 8493344 [details] [diff] [review] Fix drawing of padded single color optimized images, v2 (Gecko 33 / Beta) Requesting QA to help verify once this lands on 2.0

I verified this bug on: FF33.0b7 OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 13.04 x64 On mac I've noticed that when you zoom in zoom out on the page http://www.versicherungsjournal.de/yellowdot_alt.gif white borders are drawn around the red square. Not sure if this is related with the fix.

I think the white border thing is separate - I remember seeing that on other images. Can't seem to reproduce it on Aurora / Gecko 34 though.

Verified it on FxOS v2.0. I can see the red square via Browser app and Gallery app. As attached screenshot.(Red_square.png) * Build information: - Gaia 279c5ee3a2b4cfd1484196a409e05ef579de1b53 - Gecko https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f5655da30c8b - BuildID 20141002160200 - Version 32.0 - ro.build.version.incremental=27 - ro.build.date=Thu Sep 4 14:59:02 CST 2014

Verfied as fixed using the following environment: FF 33 RC Build Id: 20141007073543 FF 34 Build Id: 20141007004003 FF 35 Build Id: 20141007030202 OS: Win 7 x64, Mac Os X 10.10, Ubuntu 13.04 x64 Also for the issue described on comment 25 I've logged bug 1079734

Verify passed, this issue can't be repro on Woodduck 2.0; Flame2.0&2.1&2.2. Attachment:Verify_Woodduck_GIF.MP4 Reproducing rate: 0/5 Woodduck 2.0 build: Gaia-Rev 60146ec47cd38a8be8ed22e0116902eceb9ac067 Gecko-Rev cdfbe9866cf0b71b33454926638ce0cd8bb1fb00 Build-ID 20141117050313 Version 32.0 Flame 2.0 build: Gaia-Rev 086a668942292168f312b3bb53e275fa0886fab1 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/a57b299c5cf2 Build-ID 20141116000206 Version 32.0 Flame2.1 build: Gaia-Rev 81160ad79e5b4c21967418dd63f1a1d08d77924e Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/3572aa3e6766 Build-ID 20141116001201 Version 34.0 Flame2.2 build: Gaia-Rev 1dd8ad8f96988afebc9691e1b818fa37aa32c790 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/a52bf59965a0 Build-ID 20141116040209 Version 36.0a1