Closed Bug 1062940 Opened 10 years ago Closed 10 years ago

Please increase bmo's alias length to match bugzilla 5.0 (40 chars instead of 20)

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Callek, Assigned: dkl)

Details

Attachments

(1 file, 1 obsolete file)

Per IRC this should be easily doable though it involves edits to many files since its not a const (at least now) I was told that Bugzilla 5.0 uses 40 chars instead of 20, so lets go with that. This will require a schema change
Attached patch 1062940_1.patch (obsolete) (deleted) — Splinter Review
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #8499824 - Flags: review?(glob)
Comment on attachment 8499824 [details] [diff] [review] 1062940_1.patch Review of attachment 8499824 [details] [diff] [review]: ----------------------------------------------------------------- you also need to update show_bug's input field to increase the maxlength to 40.
Attachment #8499824 - Flags: review?(glob) → review-
Attached patch 1062940_2.patch (deleted) — Splinter Review
Attachment #8499824 - Attachment is obsolete: true
Attachment #8508710 - Flags: review?(glob)
Comment on attachment 8508710 [details] [diff] [review] 1062940_2.patch Review of attachment 8508710 [details] [diff] [review]: ----------------------------------------------------------------- r=glob with the change to size="30" and s/maxsize/maxlength/ even though there's a schema change, it's ok to commit this patch all at once. ::: template/en/default/bug/create/create.html.tmpl @@ +455,4 @@ > field = bug_fields.alias editable = 1 > %] > <td colspan="2"> > + <input name="alias" size="40" maxsize="40" value="[% alias FILTER html %]"> size="40" here looks messy, because it's a different size from the other inputs on create bug. use size="30" so it aligns with the assignee, cc, and depend on fields. maxsize isn't valid, you want maxlength.
Attachment #8508710 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 0e1bc26..09ff8ee master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Ah this is great - only yesterday was I struggling to fit the desired terms for a meta bug in the alias field :-)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: