Closed
Bug 1063039
Opened 10 years ago
Closed 10 years ago
Status bar needs to ignore continuous 'audio-channel-changed' event if the channel is the same.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
alive
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details |
'audio-channel-changed' event is fired every time when screen reader speaks. This triggers the redraw based on audio play icon and, if screen reader focus is inside the statusbar, the focus also jumps.
Assignee | ||
Comment 1•10 years ago
|
||
This also improves performance when the screen reader is on.
Attachment #8484398 -
Flags: review?(alive)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8484398 [details]
Github pull request.
I think this summary should be corrected to
"Status bar needs to ignore continuous 'audio-channel-changed' event if the channel is the same."
Attachment #8484398 -
Flags: review?(alive) → review+
Assignee | ||
Updated•10 years ago
|
Summary: Status bar needs to ignore 'audio-channel-changed' event when the screen reader speaks. → Status bar needs to ignore continuous 'audio-channel-changed' event if the channel is the same.
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
This is a change to significantly improve system performance when the screen reader is on.
[Bug caused by] every time screen reader speaks, it is accompanied by the 'audio-channel-changed' event, even though the channel does not change. This triggers a complete status bar rewrite that affects the overall performance.
[User impact] If anyone enables the screen reader on the device, they will see a noticable performance hit when using it.
[Risk to taking this patch] The pull request is fairly simple + there are unit tests along with it.
[String changes made] None
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8484398 [details]
Github pull request.
This is a change to significantly improve system performance when the screen reader is on.
[Bug caused by] (feature/regressing bug #): every time screen reader speaks, it is accompanied by the 'audio-channel-changed' event, even though the channel does not change. This triggers a complete status bar rewrite that affects the overall performance.
[User impact] if declined: If anyone enables the screen reader on the device, they will see a noticable performance hit when using it.
[Testing completed]: New unit tests pass on try.
[Risk to taking this patch] (and alternatives if risky): The pull request is fairly simple + there are unit tests along with it.
[String changes made]: None
Attachment #8484398 -
Flags: approval-gaia-v2.1?
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Attachment #8484398 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 6•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•