Closed Bug 1063085 Opened 10 years ago Closed 10 years ago

Get rid of calIDateTime::jsDate

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Fix - v1
(deleted), patch
standard8
: review+
redDragon
: review+
standard8
: approval-calendar-aurora+
Details | Diff | Splinter Review
Attached patch Fix - v1 (deleted) — — Splinter Review
In order to fix bug 1054738 we should get rid of the jsDate property. There is a simple replacement. I've tested this with MOZ_DISABLE_EXPORT_JS=1 (not a full clobber though) and all tests pass.
Attachment #8484452 - Flags: review?(mohit.kanwal)
Comment on attachment 8484452 [details] [diff] [review] Fix - v1 Review of attachment 8484452 [details] [diff] [review]: ----------------------------------------------------------------- I've given this a quick look and it looks reasonable. r=Standard8 if you want it.
Attachment #8484452 - Flags: review+
Comment on attachment 8484452 [details] [diff] [review] Fix - v1 Thanks, I'll take it!
Attachment #8484452 - Flags: review?(mohit.kanwal)
https://hg.mozilla.org/comm-central/rev/61dd7dc61dc4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.7
Comment on attachment 8484452 [details] [diff] [review] Fix - v1 Looks like we also need this on aurora
Attachment #8484452 - Flags: approval-calendar-aurora?(standard8)
Attachment #8484452 - Flags: approval-calendar-aurora?(standard8) → approval-calendar-aurora+
Comment on attachment 8484452 [details] [diff] [review] Fix - v1 Review of attachment 8484452 [details] [diff] [review]: ----------------------------------------------------------------- looks good. Apologies for a delay in the review. ::: calendar/base/content/calendar-base-view.xml @@ +511,4 @@ > > <method name="today"> > <body><![CDATA[ > + var d = cal.jsDateToDateTime(new Date()).getInTimezone(this.mTimezone); we can use let here.
Attachment #8484452 - Flags: review+
Blocks: 1081031
Depends on: 1082286
Depends on: 1331265
No longer depends on: 1331265
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: