Closed
Bug 1063087
Opened 10 years ago
Closed 10 years ago
[marionette-apps] Memoize homescreenURL for app launch
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikehenrty, Assigned: mikehenrty)
Details
(Whiteboard: [systemsfe])
Attachments
(3 files)
Right now, for every app launch we query the homescreen URL from settings [1]. There have been some intermittent timeouts from this when launching multiple times so let's memoize it.
1.) https://github.com/mozilla-b2g/marionette-apps/blob/b242a28ffcd03778141a26b05e20dee406648f84/lib/launch.js#L9
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8484598 -
Flags: review?(jlal)
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8484598 [details]
[Pull Request] Memoize homescreenURL
landed: https://github.com/mozilla-b2g/marionette-apps/commit/c8ffb75a21bad91dc65ca112df4a104c8a153059
published.
Attachment #8484598 -
Flags: review?(jlal) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8485258 -
Flags: review?(jlal)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8485258 -
Flags: review?(kgrandon)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8485258 [details]
[gaia-node-modules PR] memoize homescreen url
Seems fine. You can put r=me for the gaia bump as well. Thanks!
Attachment #8485258 -
Flags: review?(kgrandon)
Attachment #8485258 -
Flags: review?(jlal)
Attachment #8485258 -
Flags: review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8485258 [details]
[gaia-node-modules PR] memoize homescreen url
gaia-node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/76498b67c669b0f605ebc9db129d71285a64f343
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•