Closed
Bug 1063271
Opened 10 years ago
Closed 10 years ago
Global selection in NS_ScriptErrorReporter isn't quite right
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | unaffected |
firefox34 | + | fixed |
firefox35 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I screwed this up in bug 796938 part 10. The specific case that isn't handled here is when the most-recent AutoJSAPI was initialized with InitWithLegacyErrorReporting. In that case, the stack-top cx that we were using before won't match the entry that we pull off of the script settings stack.
The easiest thing to do is just to back that part out (in an elegant manner to avoid reindentation churn). This will all get fixed up in bug 981187, which is coming very soon down the pipe.
Note - We should backport fix to Aurora.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8484685 -
Flags: review?(bugs)
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
[Tracking Requested - why for this release]:
Potential regression from bug 796938. Just going to back that part out.
tracking-firefox34:
--- → ?
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #0)
> I screwed this up in bug 796938 part 10. The specific case that isn't
> handled here is when the most-recent AutoJSAPI was initialized with
> InitWithLegacyErrorReporting. In that case, the stack-top cx that we were
> using before won't match the entry that we pull off of the script settings
> stack.
Huh.
Updated•10 years ago
|
Attachment #8484685 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8484685 [details] [diff] [review]
Undo bug 796938 part 10. v1
Approval Request Comment
[Feature/regressing bug #]: bug 796938
[User impact if declined]: Errors might be reported in the wrong place in certain edge cases.
[Describe test coverage new/current, TBPL]: None. This is a backout.
[Risks and why]: Extremely low. This is a backout.
[String/UUID change made/needed]: None.
Attachment #8484685 -
Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
status-firefox32:
--- → unaffected
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → fixed
Comment 9•10 years ago
|
||
Attachment #8484685 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•