Closed Bug 1063305 Opened 10 years ago Closed 10 years ago

[NFC] NFC icon disappear on status bar after reboot device

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 fixed)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- fixed

People

(Reporter: ashiue, Assigned: apastor)

References

Details

(Keywords: regression, Whiteboard: [2.1-FL-bug-bash][systemsfe])

Attachments

(3 files)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23964
(deleted), text/x-github-pull-request
alive
: review+
mikehenrty
: feedback+
fabrice
: approval-gaia-v2.1+
Details
TESTS: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25274
(deleted), text/x-github-pull-request
mikehenrty
: review+
Details
video of verify issue
(deleted), video/mp4
Details
Gaia a47ecb6368c015dd72148acde26413fd90ba3136 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/c1e0cea51571 BuildID 20140904160202 Version 34.0a2 STR: 1. Enable NFC 2. Reboot device 3. Check status bar Expect result: NFC icon should show on status bar Actual result: NFC icon disappear but NFC function works well
[Blocking Requested - why for this release]: Obvious error
blocking-b2g: --- → 2.1?
QA Whiteboard: [COM=NFC]
Whiteboard: [2.1-FL-bug-bash]
Seems depend on Bug 1035250. After revert it the NFC icon is back after reboot. It seems the window.addEventListener('nfc-state-changed', this); in statusbar.js is called *after* the nfc-state-changed event is dispatched. So statusbar.js didn't receive the event. Michael, can you take a look? Thanks
Depends on: 1035250
Flags: needinfo?(mhenretty)
Yeah, I'll take care of this. My thinking is that we will want an NFC module to handle the event listening, and track NFC state. Then statusbar can rely on this when it is ready to display statusbar icons.
Assignee: nobody → mhenretty
Blocks: 1035250
No longer depends on: 1035250
Flags: needinfo?(mhenretty)
Whiteboard: [2.1-FL-bug-bash] → [2.1-FL-bug-bash][systemsfe]
Target Milestone: --- → 2.1 S3 (29aug)
Target Milestone: 2.1 S3 (29aug) → 2.1 S4 (12sep)
blocking-b2g: 2.1? → 2.1+
Keywords: regression
Assignee: mhenretty → apastor
Comment on attachment 8488193 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23964 Looks good to me! Left a small comment on github. Let's get alive to verify the change, since it touches a little more than just the statusbar.
Attachment #8488193 - Flags: review?(mhenretty)
Attachment #8488193 - Flags: review?(alive)
Attachment #8488193 - Flags: feedback+
Comment on attachment 8488193 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23964 The coverage in statusbar seems insufficient, r=me iff you amend the unit test.
Attachment #8488193 - Flags: review?(alive) → review+
master: https://github.com/mozilla-b2g/gaia/pull/23964
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
Please request Gaia v2.1 approval on this when you get a chance.
Flags: needinfo?(apastor)
Comment on attachment 8488193 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23964 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): - [User impact] if declined: NFC icon is not updated on startup. [Testing completed]: Added unit tests to cover the use cases. [Risk to taking this patch] (and alternatives if risky): 2 liner. Low risk [String changes made]: -
Attachment #8488193 - Flags: approval-gaia-v2.1?(fabrice)
Flags: needinfo?(apastor)
Attachment #8488193 - Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Verified on: [master] Gaia 72262d054ffa5d0d2b5a0033f713149281511aea Gecko https://hg.mozilla.org/mozilla-central/rev/4f2cac8d72da BuildID 20140917160215 Version 35.0a1 [v2.1] Gaia 379e68fe729a684fa2fcddb30ea1e65508db73e1 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/7ff763eb328b BuildID 20140918000204 Version 34.0a2
Status: RESOLVED → VERIFIED
Comment on attachment 8506964 [details] TESTS: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25274 Thanks!
Attachment #8506964 - Flags: review?(mhenretty) → review+
status-b2g-v2.1: fixed → verified
Attached video video of verify issue (deleted) —
This issue has been successfully verified on Flame 2.1 See attachment: verify_video.MP4 Reproducing rate: 0/5 Flame 2.1 versions: Gaia-Rev afdfa629be209dd53a1b7b6d6c95eab7077ffcd9 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6 Build-ID 20141123001201 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141123.035029 FW-Date Sun Nov 23 03:50:40 EST 2014 Bootloader L1TC00011880
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: