Closed
Bug 1063598
Opened 10 years ago
Closed 10 years ago
Infer constant properties for properties which haven't had their type information instantiated
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jandem
:
review+
abillings
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Type information for singleton object properties is lazily instantiated, and currently if we access a property during IonBuilder which hasn't been instantiated we won't treat it as a constant property. This led to a regression in sunspider-date-format-xparb, where an inlined function which never executed in baseline was not optimized by IonBuilder, then the property was instantiated, the function recompiled and optimized, changing type information and causing the earlier compilation to be invalidated. The attached patch reworks this stuff so that IonBuilder can inline constant properties even when those properties haven't been instantiated yet.
Attachment #8485031 -
Flags: review?(jdemooij)
Updated•10 years ago
|
Attachment #8485031 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8f3ce3b40944 for isNative() assertion failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=47562297&tree=Mozilla-Inbound in pretty much every test suite.
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: needinfo?(bhackett1024)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8485031 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: bug 894596
[User impact if declined]: see bug 1060276
[Describe test coverage new/current, TBPL]: none
[Risks and why]: none
Attachment #8485031 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(bhackett1024)
Comment 6•10 years ago
|
||
Comment on attachment 8485031 [details] [diff] [review]
patch
Approved for Aurora.
Attachment #8485031 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•