Build Information Device: Flame Gaia a47ecb6368c015dd72148acde26413fd90ba3136 Gecko 757931d0149e BuildID 20140904000203 Version 34.0 Description After pressing next after the timezone screen (no SIM present), the user will be unable to access the timezone screen again in the FTE. Steps to Reproduce 1. Fresh flash a Flame build (not via launching FTE in settings), no SIM 2. Press next through the timezone screen in FTE 3. Press previous in FTE Expected Results The user should return to the timezone selection screen. Actual Results The user goes to the wifi screen. Other Notes There's no recovery path here to get back to the timezone selection screen in the FTE once you go past it. For example, if I return to the wifi screen and next, then I will not be able to get to the timezone selection screen. Reproduction Frequency: 100%

I'm pretty sure this is a regression from bug 1026098. I'm adding qawanted to confirm this is a regression. If it's a confirmed regression, then I think we'll probably want to nominate this to block. Adding needinfo on Ted to see if he knows why this is happening.

Hi Jason. Yep, I know why this is happening, and I realize now that it's not desirable behaviour. I'll take this.

Unable to repro on Flame 2.2, Flame 2.1 or Flame 2.0 on both engineering and nightly builds. Also unable to repro on the reported build. Actual result: After navigating past the Date & Time page in the FTE the user can return to the page by tapping the Back button. Keeping the qawanted tag so someone else can attempt. Flame 2.2 Engineering BuildID: 20140905031309 Gaia: 5765c62163bcb7fde5ebfd211881117de31a7c46 Gecko: dddbe46f3ceb Platform Version: 35.0a1 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Nightly BuildID: 20140905040204 Gaia: 5765c62163bcb7fde5ebfd211881117de31a7c46 Gecko: dddbe46f3ceb Platform Version: 35.0a1 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Flame 2.1 Engineering BuildID: 20140905044627 Gaia: 5fa8624aaa29b12b82afa6e3805aba39c29482bd Gecko: 47f0d47da136 Platform Version: 34.0a2 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Nightly BuildID: 20140905000202 Gaia: 95e9b099aa89ded133e44014dd40b19dc0193c01 Gecko: 92a6bbdfd945 Platform Version: 34.0a2 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Flame 2.0 Engineering BuildID: 20140905063812 Gaia: 4627014cc5c5eeec894183866d4c57291302f8b8 Gecko: 1c8f11212f9c Platform Version: 32.0 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 Nightly BuildID: 20140905000204 Gaia: 4627014cc5c5eeec894183866d4c57291302f8b8 Gecko: 2fae20afe1fa Platform Version: 32.0 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

(In reply to Chris Kreinbring [:CKreinbring] from comment #3) > Unable to repro on Flame 2.2, Flame 2.1 or Flame 2.0 on both engineering and > nightly builds. Also unable to repro on the reported build. > Actual result: After navigating past the Date & Time page in the FTE the > user can return to the page by tapping the Back button. > Keeping the qawanted tag so someone else can attempt. I just retested this with a clean flash and was able to reproduce this on the first try. More details: - I did setup a wifi network before moving to the date & time screen - I did setup a date & time at the timezone screen before moving to the next screen

Ah. I just realized I'm missing a step in my above STR. The correct STR should be: 1. Fresh flash a Flame build (not via launching FTE in settings), no SIM 2. At the date & time screen, change the timezone (e.g. switch New York to LA) 3. Press next through the timezone screen in FTE 4. Press previous in FTE Step #2 was what I forgot to include.

The bug repros on Flame 2.2, Flame 2.1 and Open C 2.2 Actual result: After changing the time zone on the Date & Time page and continuing, tapping Back on the Geolocation page will go to the WiFi network page instead of the Date & Time page. Also Flame 2.2 BuildID: 20140908062801 Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d Gecko: f7a27a866c47 Platform Version: 35.0a1 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Flame 2.1 BuildID: 20140908022757 Gaia: e7ac3a51932f7f7a5b5a6935dcaad1343b7c5fa5 Gecko: d1b97cc46b5a Platform Version: 34.0a2 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0 Open C 2.2 BuildID: 20140908062801 Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d Gecko: f7a27a866c47 Platform Version: 35.0a1 Firmware Version: P821A10v1.0.0B06_LOG_DL User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 -------------------------------------------------------------------------------------------------------- The bug does not repro on Flame 2.0 Actual result: After changing the time zone on the Date & Time page and continuing, tapping Back on the Geolocation page will go to the Date & Time page. BuildID: 20140908081001 Gaia: f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5 Gecko: 0fc1d3f1a6d7 Platform Version: 32.0 Firmware Version: V123 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Not nomming - low visibility - have to go back during FTU w/ no sim in

reversing that - functional regression with no recovery - I am nomming

[Blocking Requested - why for this release]: please see prior comment

[Blocking Requested - why for this release]: This use case can happen so long as the timezone screen gets shown from the SIM not being detected (e.g. no SIM card, PIN locked SIM, no service in SIM). I hit this in dogfooding twice by accidentally clicking too quickly and wanting to correct a mistake, but I was unable to, which causes a lack of recovery path within the FTE itself. It's bad UX within the first usage of the phone & a regression, so I think we need to get this fixed.

We actually already know the regressing patch - it's likely caused by bug 1026098.

Comment on attachment 8487378 [details] Bug-1063624: Only call UIManager.tzInit once. er...is it just me, or the PR attached is not valid? It appears as a 0 commit PR already merged

Comment on attachment 8487378 [details] Bug-1063624: Only call UIManager.tzInit once. [Approval Request Comment] This has been designated a blocker by QA, so it needs to be uplifted. [Bug caused by] (feature/regressing bug #): Related to feature Bug 1026098 [User impact] if declined: If the user picks the wrong timezone in the FTU, they can't go back and select it immediately. They would have to go to Settings to correct it. [Testing completed]: It's a sea of green: https://tbpl.mozilla.org/?rev=4772cdb278c3d337b025fb372eb1c326340806b8&tree=Gaia-Try [Risk to taking this patch] (and alternatives if risky): None forseen. [String changes made]: None.

Comment on attachment 8487378 [details] Bug-1063624: Only call UIManager.tzInit once. Wait. Something's wrong with this patch. Let me check.

Let's try this again.

Comment on attachment 8488275 [details] Bug-1063624: Only call UIManager.tzInit once. How odd, I really thought I reviewed this days ago. Anyway, code looks good and works nicely on the flame. Thanks, Ted

Comment on attachment 8488275 [details] Bug-1063624: Only call UIManager.tzInit once. Comment on attachment 8487378 [details] Bug-1063624: Only call UIManager.tzInit once. [Approval Request Comment] This has been designated a blocker by QA, so it needs to be uplifted. [Bug caused by] (feature/regressing bug #): Related to feature Bug 1026098 [User impact] if declined: If the user picks the wrong timezone in the FTU, they can't go back and select it immediately. They would have to go to Settings to correct it. [Testing completed]: It's a sea of green: https://tbpl.mozilla.org/?rev=873c5fa3e2196f3ad19d571a20ecb9c481f2b47b&tree=Gaia-Try [Risk to taking this patch] (and alternatives if risky): None forseen. [String changes made]: None.

Master: https://github.com/mozilla-b2g/gaia/commit/7426a6282feba2bd50790b715e744c37cc7c88c2

Marking NO_UPLIFT for bug 1068616.

Turns out the other bug was invalid, so this should be okay to uplift.

v2.1: https://github.com/mozilla-b2g/gaia/commit/f9848662abb8122b2e682001059134e439fe171d

Issue is verified fixed in latest Flame 2.2, 2.1 (Full Flash, Nightly). Actual Results: User is able to navigate back to the Time Zone page in the FTE without a SIM card inserted. Device: Flame Master Build ID: 20141013040202 Gaia: 3b81896f04a02697e615fa5390086bd5ecfed84f Gecko: f547cf19d104 Version: 35.0a1 (Master) Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Device: Flame 2.1 Build ID: 20141013001201 Gaia: d18e130216cd3960cd327179364d9f71e42debda Gecko: 610ee0e6a776 Version: 34.0a2 Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0