Stephany Wilkes Reporter
	Description • 10 years ago

Unclear if this belongs in Homescreen or Search component. Filing under Search for now since this does not happen to the "normal" home screen.

Cancel out of search app. 
User is able to enter the home screen in landscape mode and can switch back and forth between portrait and landscape. 
This should not be able to happen: home screen should not have a landscape mode display (as it does not when, if normally on the home screen, the user turns the device and nothing changes).

	Kevin Grandon :kgrandon
	Comment 2 • 10 years ago

[Blocking Requested - why for this release]: Carrying over blocking request from bug 1063871, and seems like a poor experience.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Assignee
	Comment 3 • 10 years ago

Basically what happens here is that the orientation is unlocked when the search window is displayed. And since the underlying app is not really close, the transition controller never tell it to update the orientation.

We could forge a more elaborate patch but the orientation of the search app really depends on the orientation of the opening app since I assume we want to support landscape for the browser use case, but be portrait only for portrait only apps (since their layout is not ready to be displayed on landscape).

	Kevin Grandon :kgrandon
	Comment 4 • 10 years ago

Comment on attachment 8487564 [details] [diff] [review]
bug1063740.patch

Review of attachment 8487564 [details] [diff] [review]:
-----------------------------------------------------------------

I don't like that this makes it so we can no longer rotate the search app in the home screen =(

I do suppose that this is better than what we have today, and I think it should solve the blocker, so let's go with this for now.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Assignee
	Comment 5 • 10 years ago

(In reply to Kevin Grandon :kgrandon from comment #4)
> Comment on attachment 8487564 [details] [diff] [review]
> bug1063740.patch
> 
> Review of attachment 8487564 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't like that this makes it so we can no longer rotate the search app in
> the home screen =(
> 

The issue is that the homescreen is visible below the search app. Make the search app opaque and then we can do whatever you want :)

Also this is not only for the homescreen for what it worth. This happens for every app :/

	Kevin Grandon :kgrandon
	Comment 6 • 10 years ago

But for apps that don't lock orientation (like gallery, the browser, etc), we can still rotate which is nice. Being able to rotate the browser newtab page is probably the most important right now, and if you can't do it in an app, the user can blame the app at least :)

	Yeojin Chung [:YeojinC]
	Comment 7 • 10 years ago

Link to failed test case: https://moztrap.mozilla.org/manage/case/13755/

	Kevin Grandon :kgrandon
	Comment 8 • 10 years ago

This has been sitting for a while, so going to land it for you. In master: https://github.com/mozilla-b2g/gaia/commit/76293cc72066218e8334928c7fe0e88bb4676462

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 10 years ago

Please request Gaia v2.1 approval on this patch when you get a chance.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Assignee
	Comment 10 • 10 years ago

Comment on attachment 8487564 [details] [diff] [review]
bug1063740.patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

	[:fabrice] Fabrice Desré
	Comment 11 • 10 years ago

Comment on attachment 8487564 [details] [diff] [review]
bug1063740.patch

Next time please answer the questions in the approval template ;)

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 10 years ago

v2.1: https://github.com/mozilla-b2g/gaia/commit/469f84d8a1950b83a3ffc9f0faf17c4cfabc27eb

	[:SalvadorR]
	Comment 13 • 10 years ago

This issue is verified fix on Flame 2.1 and Flame 2.2

Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Homescreen appears properly in portrait mode after closing Rocketbar.

	Kevin Grandon :kgrandon
	Comment 14 • 10 years ago

Going to - things that depend on landscape b2g desktop support for now, and we can revisit once we have it.