Bug 1014994 landed a Remote Tabs home panel. Bug 1063750 tracks messaging users gently that their synced tabs tray has moved to be a home panel. This ticket tracks removing the code and assets for the synced tabs tray from the tree entirely. This should ride the train after Bug 1063750 lands.

Huh, I can't make this tracking-firefox36. I've marked its dependent ticket tracking-firefox35; this should ride one train later.

mhaigh is doing some work in larch that might conflict with this a bit. mhaigh, please keep an eye on these changes.

Don't think this'll change anything I'm doing, but will keep an eye on it.

This should land right at the end of the Fennec 36 cycle, since we may be uplifting code changes to Aurora.

This mops up the bits of the Remote Tabs tray not already deleted by Bug 1014994. Tested locally on a phone; charging my tablet.

This mops up the bits of the Remote Tabs tray not already deleted by Bug 1014994. mcomella: sorry, missed a spot. Having trouble with IntelliJ and files linked in multiple places.

This mops up the bits of the Remote Tabs tray not already deleted by Bug 1014994. And a little more. Sorry!

Comment on attachment 8517240 [details] [diff] [review] Remove Remote Tabs tray from Fennec entirely. Review of attachment 8517240 [details] [diff] [review]: ----------------------------------------------------------------- lgtm provided a green try run. ::: mobile/android/base/tabs/TabsPanel.java @@ +194,5 @@ > @Override > public void onTabChanged(int index) { > if (index == 0) { > show(Panel.NORMAL_TABS); > } else if (index == 1) { Maybe add an `else { throw... }` clause?

> ::: mobile/android/base/tabs/TabsPanel.java > @@ +194,5 @@ > > @Override > > public void onTabChanged(int index) { > > if (index == 0) { > > show(Panel.NORMAL_TABS); > > } else if (index == 1) { > > Maybe add an `else { throw... }` clause? This is reasonable, but I instead took the old pattern of defaulting to the last entry (in this case, PRIVATE_TABS).

This mops up the bits of the Remote Tabs tray not already deleted by Bug 1014994. This incorporates mcomella's feedback. The tree is closed so marking checkin-needed and carrying over the r+.

Hi Nick, seems this patch didn't apply cleanly: applying Bug-1063753---Remove-Remote-Tabs-tray-from-Fennec-.patch patching file mobile/android/base/moz.build Hunk #1 FAILED at 386 1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/moz.build.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh Bug-1063753---Remove-Remote-Tabs-tray-from-Fennec-.patch could you take a look, thanks!